[CronJob] Add RayCronJob related YAML#4577
Merged
Merged
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Member
|
cc @JiangJiaWei1103 @seanlaii @win5923 to help take a look, tks |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing RayCronJob-related RBAC manifests and configuration so RayCronJob can be enabled and managed consistently alongside existing RayJob/RayService support in both the Helm chart and the operator’s config bundle.
Changes:
- Add RayCronJob editor/viewer ClusterRole manifests to the Helm chart templates and to
ray-operator/config/rbac/. - Add a
RayCronJobfeature gate entry to the Helm chartvalues.yaml(and reflect it in the chart README). - Update the Helm render helper script to include the new RayCronJob RBAC templates.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/helm-render-yaml.sh | Includes RayCronJob RBAC templates in scripted Helm rendering. |
| ray-operator/config/rbac/ray_raycronjob_viewer_role.yaml | Adds end-user viewer ClusterRole for RayCronJob (manual apply). |
| ray-operator/config/rbac/ray_raycronjob_editor_role.yaml | Adds end-user editor ClusterRole for RayCronJob (manual apply). |
| helm-chart/kuberay-operator/values.yaml | Adds RayCronJob to Helm-managed feature gates. |
| helm-chart/kuberay-operator/templates/ray_raycronjob_viewer_role.yaml | Adds Helm-templated viewer ClusterRole for RayCronJob. |
| helm-chart/kuberay-operator/templates/ray_raycronjob_editor_role.yaml | Adds Helm-templated editor ClusterRole for RayCronJob. |
| helm-chart/kuberay-operator/README.md.gotmpl | Updates CRD list to include RayCronJob. |
| helm-chart/kuberay-operator/README.md | Regenerated/updated docs reflecting RayCronJob and the new feature gate entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rueian
approved these changes
Mar 10, 2026
hango880623
pushed a commit
to hango880623/kuberay
that referenced
this pull request
Mar 13, 2026
* feat: add raycronjob editor and viewer role Signed-off-by: machichima <nary12321@gmail.com> * feat: add feature gate to values.yaml Signed-off-by: machichima <nary12321@gmail.com> * feat: add raycronjob editor and viewer role to rbac Signed-off-by: machichima <nary12321@gmail.com> * feat: add raycronjob editor/viewer YAML in helm-render-yaml script Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some of the YAML file/config fields are missing for RayCronJob. This PR adds them back.
helm-chart/kuberay-operator/templates/helm installray-operator/config/rbac/kustomization.yamlresources, so user will need to apply them manuallyhelm-chart/kuberay-operator/values.yamlRelated issue number
Checks