[tune] Fix Pausing and Error Propogation#2815
Conversation
|
Can you also change the smoke test iterations for the pbt test to something like 20? That catches the bug and also runs reasonably fast. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
@joyyoj Can you take a look please? |
|
Test FAILed. |
|
jenkins retest this please |
|
Test FAILed. |
|
Jenkins retest this please |
|
Test PASSed. |
|
the changes make sense. |
| """ | ||
| raise NotImplementedError("Subclasses of TrialExecutor must provide " | ||
| "fetch_one_result() method") | ||
| raise NotImplementedError |
There was a problem hiding this comment.
So one other way of doing this is to have fetch_one_result() return an exception object for the result if there is an error. This avoids having a separate call just for this error handling.
|
Merging now since this is a fairly severe regression. Comments can be done in a follow-up... |
What do these changes do?
Addresses #2814 and #2810.
ray.get.Related issue number
Above.