Skip to content

[tune] Fix Pausing and Error Propogation#2815

Merged
ericl merged 6 commits into
ray-project:masterfrom
richardliaw:tune_fix_pausing
Sep 4, 2018
Merged

[tune] Fix Pausing and Error Propogation#2815
ericl merged 6 commits into
ray-project:masterfrom
richardliaw:tune_fix_pausing

Conversation

@richardliaw

Copy link
Copy Markdown
Contributor

What do these changes do?

Addresses #2814 and #2810.

  • Manages error handling with recovery, even when error occurs at ray.get.
  • Also introduces tests for pausing via trial executor.

Related issue number

Above.

@ericl

ericl commented Sep 3, 2018

Copy link
Copy Markdown
Contributor

Can you also change the smoke test iterations for the pbt test to something like 20? That catches the bug and also runs reasonably fast.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7958/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7961/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7968/
Test PASSed.

@richardliaw

Copy link
Copy Markdown
Contributor Author

@joyyoj Can you take a look please?

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7972/
Test FAILed.

@richardliaw

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7974/
Test FAILed.

@richardliaw

Copy link
Copy Markdown
Contributor Author

Jenkins retest this please

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7975/
Test PASSed.

@richardliaw richardliaw requested a review from ericl September 4, 2018 07:09
@joyyoj

joyyoj commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

the changes make sense.

@ericl ericl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based on tests and @joyyoj 's approval (I did not look carefully at the unpause crash, it looks complicated)

One minor suggestion on the error handling that might give a cleaner interface.

"""
raise NotImplementedError("Subclasses of TrialExecutor must provide "
"fetch_one_result() method")
raise NotImplementedError

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one other way of doing this is to have fetch_one_result() return an exception object for the result if there is an error. This avoids having a separate call just for this error handling.

@ericl ericl merged commit 72542c9 into ray-project:master Sep 4, 2018
@ericl

ericl commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Merging now since this is a fairly severe regression. Comments can be done in a follow-up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants