Skip to content

Remove dependence on psutil. Add utility functions for getting system memory.#2892

Merged
raulchen merged 2 commits into
ray-project:masterfrom
robertnishihara:removepsutil
Sep 18, 2018
Merged

Remove dependence on psutil. Add utility functions for getting system memory.#2892
raulchen merged 2 commits into
ray-project:masterfrom
robertnishihara:removepsutil

Conversation

@robertnishihara

@robertnishihara robertnishihara commented Sep 16, 2018

Copy link
Copy Markdown
Collaborator

This removes the dependence on psutil. We really only needed psutil to get the cpu count, which we can do with multiprocessing, and to get the memory size. Memory size is a bit trickier. I used some code from the psutil tests to try to do the same thing.

This fixes #2806.

To look into before merging:

  • Try on more platforms (e.g., CentOS).
  • Make sure license is ok (psutil is BSD I believe)
@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8250/
Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8253/
Test PASSed.

@raulchen raulchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please let me know when the todos are done, then I'll merge it.

@robertnishihara

Copy link
Copy Markdown
Collaborator Author

@raulchen Thanks, I think this is ok to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants