Remove dependence on psutil. Add utility functions for getting system memory.#2892
Merged
Merged
Conversation
|
Test FAILed. |
|
Test PASSed. |
raulchen
approved these changes
Sep 17, 2018
raulchen
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please let me know when the todos are done, then I'll merge it.
Collaborator
Author
|
@raulchen Thanks, I think this is ok to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependence on psutil. We really only needed psutil to get the cpu count, which we can do with multiprocessing, and to get the memory size. Memory size is a bit trickier. I used some code from the psutil tests to try to do the same thing.
This fixes #2806.
To look into before merging: