Skip to content

[autoscaler] Add option to allow private ips only#3270

Merged
pcmoritz merged 7 commits into
ray-project:masterfrom
ericl:ip-option
Nov 9, 2018
Merged

[autoscaler] Add option to allow private ips only#3270
pcmoritz merged 7 commits into
ray-project:masterfrom
ericl:ip-option

Conversation

@ericl

@ericl ericl commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

What do these changes do?

Add option to allow for private launch only. We retain the check since usually not mapping ips leads to unexpected hangs.

Related issue number

Closes #3266.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9179/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9181/
Test PASSed.

Comment thread python/ray/autoscaler/autoscaler.py Outdated
Comment thread python/ray/autoscaler/autoscaler.py Outdated
Comment thread python/ray/autoscaler/aws/config.py Outdated
richardliaw and others added 4 commits November 7, 2018 15:35
Co-Authored-By: ericl <ekhliang@gmail.com>
Co-Authored-By: ericl <ekhliang@gmail.com>
Co-Authored-By: ericl <ekhliang@gmail.com>
@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9192/
Test PASSed.

@robertnishihara

Copy link
Copy Markdown
Collaborator

When would someone want to use this option?

@mattearllongshot

Copy link
Copy Markdown
Contributor

@robertnishihara this option is necessary for us as we'd like to spin up the cluster inside a VPC, so that the workers aren't accessible externally.

@robertnishihara

Copy link
Copy Markdown
Collaborator

@mattearllongshot Ok, that makes sense. Seems good to me.

Any reason not to use this option all the time?

@ericl

ericl commented Nov 8, 2018 via email

Copy link
Copy Markdown
Contributor Author
@pcmoritz pcmoritz merged commit 588705b into ray-project:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants