[autoscaler] Add option to allow private ips only#3270
Conversation
|
Test PASSed. |
|
Test PASSed. |
Co-Authored-By: ericl <ekhliang@gmail.com>
Co-Authored-By: ericl <ekhliang@gmail.com>
Co-Authored-By: ericl <ekhliang@gmail.com>
|
Test PASSed. |
|
When would someone want to use this option? |
|
@robertnishihara this option is necessary for us as we'd like to spin up the cluster inside a VPC, so that the workers aren't accessible externally. |
|
@mattearllongshot Ok, that makes sense. Seems good to me. Any reason not to use this option all the time? |
|
This option doesn't work unless you have a VPN connection to the network.
…On Thu, Nov 8, 2018, 11:59 AM Robert Nishihara ***@***.***> wrote:
@mattearllongshot <https://github.com/mattearllongshot> Ok, that makes
sense. Seems good to me.
Any reason not to use this option all the time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3270 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA6Soxu9yPNWa_7zRagNBdtTKocmZVNks5utI0wgaJpZM4YS_wX>
.
|
What do these changes do?
Add option to allow for private launch only. We retain the check since usually not mapping ips leads to unexpected hangs.
Related issue number
Closes #3266.