[rllib] Use smoothed version of collect metrics for DQN#3491
Merged
Conversation
|
Test PASSed. |
richardliaw
approved these changes
Dec 7, 2018
richardliaw
left a comment
richardliaw
left a comment
Contributor
There was a problem hiding this comment.
i think evaluation.collect_metrics is no longer used so there might be lint errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The prior version does not pull from the history buffer, resulting in NaNs sometimes if no episodes finished in the training step.
Related issue number
Closes #3030