Skip to content

[tune] resume=False by default but print a tip to set resume="prompt" + jenkins fix#3681

Merged
richardliaw merged 5 commits into
ray-project:masterfrom
ericl:tune-prompt
Jan 5, 2019
Merged

[tune] resume=False by default but print a tip to set resume="prompt" + jenkins fix#3681
richardliaw merged 5 commits into
ray-project:masterfrom
ericl:tune-prompt

Conversation

@ericl

@ericl ericl commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

I'm finding that the prompt is quite annoying, and maybe isn't the common case. This is a try to make the default False while still making the feature visible via a tip.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10570/
Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10571/
Test FAILed.

@richardliaw richardliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the readthedocs too?

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10587/
Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10590/
Test FAILed.

obs = torch.from_numpy(obs).float().unsqueeze(0)
_, _, vf, _ = self.model({"obs": obs}, [])
return vf.numpy().squeeze()
return vf.detach().numpy().squeeze()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericl going to include this jenkins fix in this PR

@richardliaw richardliaw changed the title [tune] resume=False by default but print a tip to set resume="prompt" Jan 4, 2019
@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10591/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants