[autoscaler] GCP: only call setIamPolicy if necessary#3782
Merged
Conversation
|
Test PASSed. |
ericl
approved these changes
Jan 15, 2019
ericl
left a comment
ericl
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for fixing this. fyi @hartikainen
Contributor
|
One of the lint tests is failing on this PR |
Contributor
Author
How can you see what the failure was? It just seems to say there was a failure. |
Contributor
Author
|
fixed it |
|
Test PASSed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Avoids trying to call setIamPolicy if they already exist.
setIamPolicy may fail in environments where the user doesn't have permission to do so
Related issue number
No