Skip to content

Test raylet and plasma store in valgrind.#3811

Closed
robertnishihara wants to merge 9 commits into
ray-project:masterfrom
robertnishihara:morevalgrind
Closed

Test raylet and plasma store in valgrind.#3811
robertnishihara wants to merge 9 commits into
ray-project:masterfrom
robertnishihara:morevalgrind

Conversation

@robertnishihara

Copy link
Copy Markdown
Collaborator

This fixes #2896. It replaces #3701 and #3005. Note that we currently do not test the raylet_monitor in valgrind because doing so leads to a valgrind error.

Comment thread python/ray/services.py
return object_store_memory, plasma_directory


def _start_plasma_store(plasma_store_memory,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied over from plasma.py, which I removed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10971/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10972/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10974/
Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11015/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11033/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11031/
Test PASSed.

@pcmoritz

Copy link
Copy Markdown
Contributor

Here are some linting errors to be fixed:

Running clang-format against branch master, with hash f0e65233234f8f4fb65931331fd64f765fc0dd33
clang-format failed:
diff --git a/src/ray/object_manager/test/object_manager_stress_test.cc b/src/ray/object_manager/test/object_manager_stress_test.cc
index 84c1baf..761f6f6 100644
--- a/src/ray/object_manager/test/object_manager_stress_test.cc
+++ b/src/ray/object_manager/test/object_manager_stress_test.cc
@@ -70,7 +70,8 @@ class MockServer {
   void HandleAcceptObjectManager(const boost::system::error_code &error) {
     ClientHandler<boost::asio::ip::tcp> client_handler =
         [this](std::shared_ptr<TcpClientConnection> client) {
-            object_manager_.ProcessNewClient(*client); };
+          object_manager_.ProcessNewClient(*client);
+        };
     MessageHandler<boost::asio::ip::tcp> message_handler = [this](
         std::shared_ptr<TcpClientConnection> client, int64_t message_type,
         const uint8_t *message) {
diff --git a/src/ray/object_manager/test/object_manager_test.cc b/src/ray/object_manager/test/object_manager_test.cc
index d4473f6..7ee7167 100644
--- a/src/ray/object_manager/test/object_manager_test.cc
+++ b/src/ray/object_manager/test/object_manager_test.cc
@@ -61,7 +61,8 @@ class MockServer {
   void HandleAcceptObjectManager(const boost::system::error_code &error) {
     ClientHandler<boost::asio::ip::tcp> client_handler =
         [this](std::shared_ptr<TcpClientConnection> client) {
-            object_manager_.ProcessNewClient(*client); };
+          object_manager_.ProcessNewClient(*client);
+        };
     MessageHandler<boost::asio::ip::tcp> message_handler = [this](
         std::shared_ptr<TcpClientConnection> client, int64_t message_type,
         const uint8_t *message) {
diff --git a/src/ray/raylet/raylet.cc b/src/ray/raylet/raylet.cc
index 8a3765f..6fc7a66 100644
--- a/src/ray/raylet/raylet.cc
+++ b/src/ray/raylet/raylet.cc
@@ -92,9 +92,10 @@ void Raylet::DoAcceptNodeManager() {
 
 void Raylet::HandleAcceptNodeManager(const boost::system::error_code &error) {
   if (!error) {
-    ClientHandler<boost::asio::ip::tcp> client_handler = [this](
-        std::shared_ptr<TcpClientConnection> client) {
-            node_manager_.ProcessNewNodeManager(*client); };
+    ClientHandler<boost::asio::ip::tcp> client_handler =
+        [this](std::shared_ptr<TcpClientConnection> client) {
+          node_manager_.ProcessNewNodeManager(*client);
+        };
     MessageHandler<boost::asio::ip::tcp> message_handler = [this](
         std::shared_ptr<TcpClientConnection> client, int64_t message_type,
         const uint8_t *message) {
@@ -118,7 +119,8 @@ void Raylet::DoAcceptObjectManager() {
 void Raylet::HandleAcceptObjectManager(const boost::system::error_code &error) {
   ClientHandler<boost::asio::ip::tcp> client_handler =
       [this](std::shared_ptr<TcpClientConnection> client) {
-          object_manager_.ProcessNewClient(*client); };
+        object_manager_.ProcessNewClient(*client);
+      };
   MessageHandler<boost::asio::ip::tcp> message_handler = [this](
       std::shared_ptr<TcpClientConnection> client, int64_t message_type,
       const uint8_t *message) {
@@ -142,7 +144,8 @@ void Raylet::HandleAccept(const boost::system::error_code &error) {
     // TODO: typedef these handlers.
     ClientHandler<boost::asio::local::stream_protocol> client_handler =
         [this](std::shared_ptr<LocalClientConnection> client) {
-            node_manager_.ProcessNewClient(client); };
+          node_manager_.ProcessNewClient(client);
+        };
     MessageHandler<boost::asio::local::stream_protocol> message_handler = [this](
         std::shared_ptr<LocalClientConnection> client, int64_t message_type,
         const uint8_t *message) {
diff --git a/src/ray/raylet/worker_pool_test.cc b/src/ray/raylet/worker_pool_test.cc
index d1ae138..b46de47 100644
--- a/src/ray/raylet/worker_pool_test.cc
+++ b/src/ray/raylet/worker_pool_test.cc
@@ -38,8 +38,8 @@ class WorkerPoolTest : public ::testing::Test {
 
   std::shared_ptr<Worker> CreateWorker(pid_t pid,
                                        const Language &language = Language::PYTHON) {
-    std::function<void(std::shared_ptr<LocalClientConnection>)> client_handler =
-        [this](std::shared_ptr<LocalClientConnection> client) { HandleNewClient(*client); };
+    std::function<void(std::shared_ptr<LocalClientConnection>)> client_handler = [this](
+        std::shared_ptr<LocalClientConnection> client) { HandleNewClient(*client); };
     std::function<void(std::shared_ptr<LocalClientConnection>, int64_t, const uint8_t *)>
         message_handler = [this](std::shared_ptr<LocalClientConnection> client,
                                  int64_t message_type, const uint8_t *message) {
The command ".travis/check-git-clang-format-output.sh" exited with 1.
@robertnishihara

Copy link
Copy Markdown
Collaborator Author

Most of the code here was merged in #3824. Except that there are some valgrind errors in the raylet and raylet monitor so those aren't being tested yet.

@robertnishihara robertnishihara deleted the morevalgrind branch January 22, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants