Skip to content

Compile raylet cython bindings with bazel#3842

Merged
robertnishihara merged 7 commits into
ray-project:masterfrom
pcmoritz:baselize-cython
Jan 25, 2019
Merged

Compile raylet cython bindings with bazel#3842
robertnishihara merged 7 commits into
ray-project:masterfrom
pcmoritz:baselize-cython

Conversation

@pcmoritz

@pcmoritz pcmoritz commented Jan 24, 2019 •
edited by robertnishihara
Loading

Copy link
Copy Markdown
Contributor

The plasma store can be built with:

bazel build @plasma//:plasma_server -c opt

And the raylet can be built with:

bazel build //:_raylet -c opt

Related to #2887.
@pcmoritz pcmoritz changed the title Add cython for compiling python bindings for raylet Jan 24, 2019
@AmplabJenkins

AmplabJenkins commented Jan 24, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11119/
Test FAILed.
robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
Comment thread bazel/cython_library.bzl
@@ -0,0 +1,71 @@
"""Custom rules for gRPC Python"""

@robertnishihara robertnishihara Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the role of this file?

@pcmoritz pcmoritz Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used to compile the .pyx files with cython, see

load("@//bazel:cython_library.bzl", "pyx_library")

in BUILD.bazel and

pyx_library(
    name = "_raylet",
    srcs = glob([
        "python/ray/_raylet.pyx",
        "python/ray/includes/*.pxd",
        "python/ray/includes/*.pxi"
    ]),
    deps = [":raylet_lib"]
)
robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
Comment thread WORKSPACE

new_git_repository(
name = "plasma",
build_file = "@//bazel:BUILD.plasma",

@robertnishihara robertnishihara Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original indentation was correct
robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
Comment thread bazel/python_configure.bzl
@@ -0,0 +1,295 @@
# Adapted with modifications from tensorflow/third_party/py/

@robertnishihara robertnishihara Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment pointing out the minor modifications you made to this file
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11124/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11121/
Test PASSed.
@pcmoritz pcmoritz force-pushed the baselize-cython branch 3 times, most recently from f06fab2 to b3a2524 Compare January 25, 2019 04:50
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11130/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11132/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11131/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11135/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11133/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11139/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11138/
Test PASSed.
@robertnishihara robertnishihara merged commit 20162ce into ray-project:master Jan 25, 2019
@robertnishihara robertnishihara deleted the baselize-cython branch January 25, 2019 08:57
@robertnishihara

robertnishihara commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

@rsepassi please take a quick look as a sanity check if you have a chance!
@rsepassi

rsepassi commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

looks good!
@robertnishihara

robertnishihara commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

Thanks @rsepassi!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@pcmoritz @AmplabJenkins @robertnishihara @rsepassi