Skip to content

[tune] Add SigOpt Integration#3844

Merged
richardliaw merged 14 commits into
ray-project:masterfrom
andrewztan:sigopt
Feb 4, 2019
Merged

[tune] Add SigOpt Integration#3844
richardliaw merged 14 commits into
ray-project:masterfrom
andrewztan:sigopt

Conversation

@andrewztan

@andrewztan andrewztan commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

What do these changes do?

Integrates Sigopt into Tune as a search algorithm.

Related issue number
@andrewztan andrewztan closed this Jan 24, 2019
@richardliaw richardliaw reopened this Jan 24, 2019
@andrewztan andrewztan closed this Jan 24, 2019
@richardliaw richardliaw reopened this Jan 24, 2019
@richardliaw

richardliaw commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Previous PR here: https://github.com/ray-project/ray/pull/1570/files
@AmplabJenkins

AmplabJenkins commented Jan 24, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11122/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Jan 25, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11123/
Test PASSed.
@richardliaw

richardliaw commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@andrewztan, are you planning to do this? can you push what you have?
@andrewztan

andrewztan commented Feb 1, 2019

Copy link
Copy Markdown
Contributor Author

Added all functions except on_trial_result
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes

@richardliaw richardliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to add this to tests and add documentation; see the bayesian opt PR and lets try to get this merged by tomorrow!
Comment thread python/ray/tune/suggest/sigopt.py Outdated
Comment thread python/ray/tune/examples/sigopt_example.py
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11373/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11379/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11376/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11381/
Test PASSed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11385/
Test FAILed.
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread python/ray/tune/suggest/sigopt.py
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread python/ray/tune/suggest/sigopt.py
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread python/ray/tune/suggest/sigopt.py Outdated
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes

@richardliaw richardliaw left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments; then we can probably merge after
@richardliaw richardliaw self-assigned this Feb 1, 2019
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11384/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11400/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Feb 1, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11405/
Test FAILed.
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread python/ray/tune/suggest/sigopt.py
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread python/ray/tune/examples/sigopt_example.py

if __name__ == '__main__':
import argparse

@richardliaw richardliaw Feb 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this example, can you also add a check for the key? (like an assertion)

@andrewztan andrewztan Feb 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i make a check for the key in sigopt.py too?
@richardliaw richardliaw changed the title [wip][tune] Add SigOpt Integration Feb 1, 2019
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
Comment thread doc/source/tune-searchalg.rst
richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes

@richardliaw richardliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments about API key
@AmplabJenkins

AmplabJenkins commented Feb 2, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11457/
Test FAILed.
richardliaw
richardliaw reviewed Feb 3, 2019
View reviewed changes
Comment thread test/jenkins_tests/run_multi_node_tests.sh Outdated
richardliaw and others added 2 commits February 2, 2019 22:41
@richardliaw @andrewztan
Update test/jenkins_tests/run_multi_node_tests.sh
0889df0 
Co-Authored-By: andrewztan <andrewztan12@gmail.com>
@andrewztan
fixed formatting
1373b0d
@AmplabJenkins

AmplabJenkins commented Feb 3, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11477/
Test FAILed.
@AmplabJenkins

AmplabJenkins commented Feb 3, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11476/
Test PASSed.
@richardliaw richardliaw merged commit 8323419 into ray-project:master Feb 4, 2019
@AmplabJenkins

AmplabJenkins commented Feb 4, 2019

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11493/
Test PASSed.
@andrewztan andrewztan deleted the sigopt branch February 4, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@andrewztan @richardliaw @AmplabJenkins