[rllib] on_train_result results do not get logged

[ericl]

What do these changes do?

Move the callback to before calling logger.on_result(). This requires a bit of a refactoring.

Related issue number

Closes #3854

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11170/
Test FAILed.

[ericl]

jenkins retest this please

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11198/
Test PASSed.

[richardliaw]

You also need to change L426 in Trial.py for when you're running with run_experiments right?

[ericl]

What do you mean?

[richardliaw]

The logging in Tune happens in Trial (on driver) even when distributed (and remote workers have a NoopLogger), so do you need to make modifications there? Basically this codepath I dont think gets hit in Tune when using run_experiments

…

On Fri, Feb 1, 2019 at 3:31 PM Eric Liang ***@***.***> wrote: What do you mean? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3865 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEUc5aqrn87RzVa4FUS659kA4H_2-79cks5vJM5TgaJpZM4aT4no> .

[ericl]

That should work fine then. The only issue is if the result is logged *before* the callback gets called. If Tune is getting it over remote call, it the callback must have fired already. On Fri, Feb 1, 2019 at 3:51 PM Richard Liaw <notifications@github.com> wrote:

…

The logging in Tune happens in Trial (on driver) even when distributed (and remote workers have a NoopLogger), so do you need to make modifications there? Basically this codepath I dont think gets hit in Tune when using run_experiments On Fri, Feb 1, 2019 at 3:31 PM Eric Liang ***@***.***> wrote: > What do you mean? > > — > You are receiving this because you were assigned. > > > Reply to this email directly, view it on GitHub > <#3865 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AEUc5aqrn87RzVa4FUS659kA4H_2-79cks5vJM5TgaJpZM4aT4no > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3865 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA6SoOPQilc74JEPtAhQl8SiN5TOV5Fks5vJNMQgaJpZM4aT4no> .