Skip to content

[Data] Lowering DEFAULT_ACTOR_MAX_TASKS_IN_FLIGHT_TO_MAX_CONCURRENCY_FACTOR to 2#58262

Merged
alexeykudinkin merged 1 commit into
masterfrom
ak/max-tsk-pnd-act-rev
Nov 12, 2025
Merged

[Data] Lowering DEFAULT_ACTOR_MAX_TASKS_IN_FLIGHT_TO_MAX_CONCURRENCY_FACTOR to 2#58262
alexeykudinkin merged 1 commit into
masterfrom
ak/max-tsk-pnd-act-rev

Conversation

@alexeykudinkin

Copy link
Copy Markdown
Contributor

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

This was setting the value to be aligned with the previous default of 4.

However, after some consideration i've realized that 4 is too high of a number so actually lowering this to 2

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

…` to 2

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin alexeykudinkin requested a review from a team as a code owner October 28, 2025 23:22
@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Oct 28, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request lowers the default value of DEFAULT_ACTOR_MAX_TASKS_IN_FLIGHT_TO_MAX_CONCURRENCY_FACTOR from 4 to 2. This change reduces the default number of tasks that can be queued per actor, which should help reduce memory pressure at the cost of potentially less task pipelining. The change itself is straightforward and seems reasonable. As a side note, I noticed a related test comment in python/ray/data/tests/test_autoscaler.py that refers to the old default value of 4 and could be updated to reflect this change, although that file is not part of this PR.

@ray-gardener ray-gardener Bot added the data Ray Data-related issues label Oct 29, 2025
@alexeykudinkin alexeykudinkin enabled auto-merge (squash) November 8, 2025 19:23
@alexeykudinkin alexeykudinkin merged commit cd09d10 into master Nov 12, 2025
7 checks passed
@alexeykudinkin alexeykudinkin deleted the ak/max-tsk-pnd-act-rev branch November 12, 2025 16:50
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…_FACTOR` to 2 (ray-project#58262)

> Thank you for contributing to Ray! 🚀
> Please review the [Ray Contribution
Guide](https://docs.ray.io/en/master/ray-contribute/getting-involved.html)
before opening a pull request.

> ⚠️ Remove these instructions before submitting your PR.

> 💡 Tip: Mark as draft if you want early feedback, or ready for review
when it's complete.

## Description

This was setting the value to be aligned with the previous default of 4.

However, after some consideration i've realized that 4 is too high of a
number so actually lowering this to 2

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
…_FACTOR` to 2 (ray-project#58262)

> Thank you for contributing to Ray! 🚀
> Please review the [Ray Contribution
Guide](https://docs.ray.io/en/master/ray-contribute/getting-involved.html)
before opening a pull request.

> ⚠️ Remove these instructions before submitting your PR.

> 💡 Tip: Mark as draft if you want early feedback, or ready for review
when it's complete.

## Description

This was setting the value to be aligned with the previous default of 4.

However, after some consideration i've realized that 4 is too high of a
number so actually lowering this to 2

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
…_FACTOR` to 2 (ray-project#58262)

> Thank you for contributing to Ray! 🚀
> Please review the [Ray Contribution
Guide](https://docs.ray.io/en/master/ray-contribute/getting-involved.html)
before opening a pull request.

> ⚠️ Remove these instructions before submitting your PR.

> 💡 Tip: Mark as draft if you want early feedback, or ready for review
when it's complete.

## Description

This was setting the value to be aligned with the previous default of 4.

However, after some consideration i've realized that 4 is too high of a
number so actually lowering this to 2

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

2 participants