Skip to content

Cleanup dashboard test and header validation#58648

Merged
edoakes merged 7 commits into
ray-project:masterfrom
edoakes:eoakes/cleanup-dashboard-test
Nov 17, 2025
Merged

Cleanup dashboard test and header validation#58648
edoakes merged 7 commits into
ray-project:masterfrom
edoakes:eoakes/cleanup-dashboard-test

Conversation

@edoakes

@edoakes edoakes commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

Getting rid of the excessive while True loops & timeouts in the tests (we already wait for the dashboard to be up).

Also just cleaned up some comments and naming while I was poking around.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team as a code owner November 14, 2025 21:05
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Nov 14, 2025
gemini-code-assist[bot]

This comment was marked as outdated.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Comment thread python/ray/dashboard/optional_utils.py Outdated
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes changed the title Cleanup dashboard test and header validatio Nov 14, 2025
@ray-gardener ray-gardener Bot added the core Issues that should be addressed in Ray Core label Nov 15, 2025
@edoakes edoakes merged commit 3a99ec8 into ray-project:master Nov 17, 2025
6 checks passed
edoakes added a commit to edoakes/ray that referenced this pull request Nov 27, 2025
Getting rid of the excessive `while True` loops & timeouts in the tests
(we already wait for the dashboard to be up).

Also just cleaned up some comments and naming while I was poking around.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
aslonnie added a commit that referenced this pull request Nov 28, 2025
Cherry pick #58553 #58648 #59042

---------

Signed-off-by: Richo Healey <richo@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Co-authored-by: richo-anyscale <richo@anyscale.com>
Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
Getting rid of the excessive `while True` loops & timeouts in the tests
(we already wait for the dashboard to be up).

Also just cleaned up some comments and naming while I was poking around.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
Getting rid of the excessive `while True` loops & timeouts in the tests
(we already wait for the dashboard to be up).

Also just cleaned up some comments and naming while I was poking around.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
weiquanlee pushed a commit to antgroup/ant-ray that referenced this pull request Dec 11, 2025
Cherry pick ray-project#58553 ray-project#58648 ray-project#59042

---------

Signed-off-by: Richo Healey <richo@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Co-authored-by: richo-anyscale <richo@anyscale.com>
Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

2 participants