Skip to content

[Data] Compute Expressions-fixed size array#58741

Merged
bveeramani merged 28 commits into
ray-project:masterfrom
400Ping:data/compute-expressions-arr
Jan 14, 2026
Merged

[Data] Compute Expressions-fixed size array#58741
bveeramani merged 28 commits into
ray-project:masterfrom
400Ping:data/compute-expressions-arr

Conversation

@400Ping

@400Ping 400Ping commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Description

Completing the fixed-size array namespace operations

Related issues

Related to #58674

Additional information
@400Ping 400Ping requested a review from a team as a code owner November 18, 2025 15:44
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 18, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new _ArrayNamespace to handle fixed-size array operations in Ray Data expressions, adding flatten() and to_list() methods. The implementation is a good start, but I've identified a couple of issues in the new arr_namespace.py file. Specifically, the flatten() method has incorrect fallback logic that makes its behavior inconsistent, and the to_list() method can be optimized for better performance. My review includes suggestions to fix these issues for improved correctness and efficiency.
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
Comment thread python/ray/data/namespace_expressions/arr_namespace.py
cursor[bot]
cursor Bot reviewed Nov 18, 2025
View reviewed changes
Comment thread python/ray/data/expressions.py Outdated
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
@400Ping 400Ping marked this pull request as draft November 18, 2025 16:37
@400Ping 400Ping marked this pull request as ready for review November 18, 2025 16:38
@400Ping 400Ping force-pushed the data/compute-expressions-arr branch from a86b794 to 000cf1e Compare November 18, 2025 16:42
@400Ping 400Ping changed the title [Data]Compute Expressions-fixed size array Nov 18, 2025
@400Ping 400Ping changed the title [WIP[Data]Compute Expressions-fixed size array Nov 18, 2025
@ray-gardener ray-gardener Bot added data Ray Data-related issues community-contribution Contributed by the community labels Nov 18, 2025
@gvspraveen

gvspraveen commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Hi @400Ping Thanks for contribution. Can you fix the CI (lint issue)?
iamjustinhsu
iamjustinhsu reviewed Nov 19, 2025
View reviewed changes

@iamjustinhsu iamjustinhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @400Ping! Can you also add some tests?
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
Comment thread python/ray/data/expressions.py Outdated
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
@400Ping 400Ping marked this pull request as draft November 20, 2025 10:27
@400Ping
[data]Compute Expressions-fixed-size-array-operations
c2b03a8 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
fix prpperty
b1615a8 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
add type-checking
950ef28 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
[data] Improve array namespace docs and tests
7819f4b 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping force-pushed the data/compute-expressions-arr branch from 987ca07 to 7819f4b Compare November 21, 2025 18:38
@400Ping
fix linter
0bc9400 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping changed the title [WIP][Data]Compute Expressions-fixed size array Nov 22, 2025
@400Ping 400Ping marked this pull request as ready for review November 22, 2025 05:56
cursor[bot]
cursor Bot reviewed Nov 22, 2025
View reviewed changes
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
@400Ping

400Ping commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

cc @goutamvenkat-anyscale PTAL
@400Ping
fix
7a51d0b 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping requested a review from iamjustinhsu November 25, 2025 06:03
goutamvenkat-anyscale
goutamvenkat-anyscale reviewed Nov 25, 2025
View reviewed changes
Comment thread python/ray/data/namespace_expressions/arr_namespace.py Outdated
@400Ping
Merge branch 'master' into data/compute-expressions-arr
6cd7558 
Signed-off-by: Ping <fourhundredping@gmail.com>
@400Ping
fix
d666c74 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
cursor[bot]
cursor Bot reviewed Nov 26, 2025
View reviewed changes
Comment thread python/ray/data/tests/test_namespace_expressions.py Outdated
@400Ping

400Ping commented Dec 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@goutamvenkat-anyscale fixed, PTAL.
@400Ping

400Ping commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

cc @iamjustinhsu
@400Ping

400Ping commented Dec 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

cc @owenowenisme @bveeramani PTAL
alexeykudinkin
alexeykudinkin reviewed Dec 11, 2025
View reviewed changes
Comment thread python/ray/data/expressions.py Outdated
@400Ping
fix
2829610 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
owenowenisme
owenowenisme reviewed Dec 14, 2025
View reviewed changes
Comment thread python/ray/data/namespace_expressions/list_namespace.py Outdated
@400Ping
update
4717267 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
Merge branch 'master' into data/compute-expressions-arr
bb6fb05
@400Ping

400Ping commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

cc @goutamvenkat-anyscale
goutamvenkat-anyscale
goutamvenkat-anyscale reviewed Dec 18, 2025
View reviewed changes
Comment thread python/ray/data/namespace_expressions/list_namespace.py Outdated
@400Ping

400Ping commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

@goutamvenkat-anyscale PTAL
@400Ping

400Ping commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@goutamvenkat-anyscale
@owenowenisme

owenowenisme commented Jan 8, 2026

Copy link
Copy Markdown
Member

@400Ping Could you fix the conflict first? Thanks.
400Ping added 2 commits January 9, 2026 22:09
@400Ping
Merge remote-tracking branch 'upstream/master' into data/compute-expr…
c46d1fa 
…essions-arr
@400Ping
fix CI error
c3d3bb2 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping

400Ping commented Jan 10, 2026

Copy link
Copy Markdown
Contributor Author

@400Ping Could you fix the conflict first? Thanks.

Done
goutamvenkat-anyscale
goutamvenkat-anyscale requested changes Jan 13, 2026
View reviewed changes

@goutamvenkat-anyscale goutamvenkat-anyscale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks.

Just a couple of comments
Comment thread python/ray/data/tests/expressions/test_namespace_list.py Outdated
@400Ping
update
aa9ded9 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
goutamvenkat-anyscale
goutamvenkat-anyscale approved these changes Jan 14, 2026
View reviewed changes

@goutamvenkat-anyscale goutamvenkat-anyscale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@400Ping
fix
2a283d8 
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@bveeramani bveeramani merged commit 28bca7a into ray-project:master Jan 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. go add ONLY when ready to merge, run all tests

8 participants

@400Ping @gvspraveen @goutamvenkat-anyscale @owenowenisme @alexeykudinkin @iamjustinhsu @omatthew98 @bveeramani