change version to 2.52.1#59049
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on bumping the version to 2.52.1 and introducing a new token-based authentication mechanism. The changes are comprehensive, including significant security enhancements like using the secrets module for token generation, extensive documentation for the new authentication feature, and refactoring of CI/build configurations. The code quality is high, with good test coverage for the new features. I have one suggestion to improve the CLI user experience by using a more appropriate exception type for error handling.
There was a problem hiding this comment.
Bug: Double period in authentication error messages
The AuthenticationError.__str__ method prepends . Ensure... to the message, but the error message constants in authentication_constants.py (like TOKEN_AUTH_ENABLED_BUT_NO_TOKEN_FOUND_ERROR_MESSAGE and TOKEN_INVALID_ERROR_MESSAGE) already end with periods. This results in double periods (..) in error output, e.g., "Token authentication is enabled but no authentication token was found.. Ensure that you have...". Either the constants should not end with periods, or __str__ should not prepend one.
python/ray/exceptions.py#L496-L501
Lines 496 to 501 in 8337334
for 2.52.1 release