Skip to content

change version to 2.52.1#59049

Merged
edoakes merged 1 commit into
releases/2.52.1from
elliot-barn/251127-2521verchange
Nov 27, 2025
Merged

change version to 2.52.1#59049
edoakes merged 1 commit into
releases/2.52.1from
elliot-barn/251127-2521verchange

Conversation

@elliot-barn

Copy link
Copy Markdown
Collaborator

for 2.52.1 release

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@elliot-barn elliot-barn changed the base branch from master to releases/2.52.1 November 27, 2025 22:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on bumping the version to 2.52.1 and introducing a new token-based authentication mechanism. The changes are comprehensive, including significant security enhancements like using the secrets module for token generation, extensive documentation for the new authentication feature, and refactoring of CI/build configurations. The code quality is high, with good test coverage for the new features. I have one suggestion to improve the CLI user experience by using a more appropriate exception type for error handling.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Double period in authentication error messages

The AuthenticationError.__str__ method prepends . Ensure... to the message, but the error message constants in authentication_constants.py (like TOKEN_AUTH_ENABLED_BUT_NO_TOKEN_FOUND_ERROR_MESSAGE and TOKEN_INVALID_ERROR_MESSAGE) already end with periods. This results in double periods (..) in error output, e.g., "Token authentication is enabled but no authentication token was found.. Ensure that you have...". Either the constants should not end with periods, or __str__ should not prepend one.

python/ray/exceptions.py#L496-L501

def __str__(self) -> str:
return self.message + (
". Ensure that you have `RAY_AUTH_MODE=token` set and the token for the cluster is available as the `RAY_AUTH_TOKEN` environment variable or a local file. "
"For more information, see: https://docs.ray.io/en/latest/ray-security/auth.html"
)

python/ray/_private/authentication/authentication_constants.py#L1-L6

# Authentication error messages
TOKEN_AUTH_ENABLED_BUT_NO_TOKEN_FOUND_ERROR_MESSAGE = (
"Token authentication is enabled but no authentication token was found."
)
TOKEN_INVALID_ERROR_MESSAGE = "Token authentication is enabled but the authentication token is invalid or incorrect." # noqa: E501

Fix in Cursor Fix in Web


@richo-anyscale richo-anyscale enabled auto-merge (squash) November 27, 2025 22:29
@edoakes edoakes disabled auto-merge November 27, 2025 22:29
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label Nov 27, 2025
@edoakes edoakes merged commit 4ebdc0a into releases/2.52.1 Nov 27, 2025
5 of 6 checks passed
@edoakes edoakes deleted the elliot-barn/251127-2521verchange branch November 27, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

3 participants