[Serve] set last scale up/down time on autoscaling context#59057
Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) | ||
|
|
||
| # Record the scaling event timestamp | ||
| self._autoscaling_state_manager.record_scaling_event(self._id, new_num, old_num) |
There was a problem hiding this comment.
Bug: Scaling event timestamp not recorded on early return
The record_scaling_event call is placed after an early return condition (lines 2340-2346). When is_within_bounds() returns False, the function returns True at line 2346 without ever calling record_scaling_event(), even though the target state was already changed at line 2336. This means scaling event timestamps won't be recorded when a deployment has running replicas outside its autoscaling bounds, causing last_scale_up_time and last_scale_down_time to be stale or None in subsequent autoscaling decisions.
harshit-anyscale
approved these changes
Dec 2, 2025
harshit-anyscale
left a comment
harshit-anyscale
left a comment
Contributor
There was a problem hiding this comment.
minor comments, else LGTM!
akyang-anyscale
approved these changes
Dec 2, 2025
Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: abrar <abrar@anyscale.com>
akyang-anyscale
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59001