[Data] Restoring ray.air.util.object_extensions.arrow class aliases to fix deserialization of existing datasets#59828
Merged
alexeykudinkin merged 2 commits intoJan 4, 2026
Conversation
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a deserialization issue by restoring class aliases for ArrowPythonObjectType under the ray.air.util.object_extensions.arrow path, ensuring backward compatibility. The approach is sound and consistent with how similar aliases are handled for tensor extensions. I have one minor suggestion to improve a comment for clarity. Otherwise, the change looks good.
Comment on lines
+1
to
+3
| # NOTE: We provide these as aliases to maintain compatibility with older version | ||
| # of Arrow `PyExtensionType` that relies on picked class references that | ||
| # reference `ray.air.util.{tensor|object}_extensions.arrow.*` classes |
Contributor
There was a problem hiding this comment.
The comment uses a generic path placeholder {tensor|object}. To improve clarity and align with the convention in similar files (e.g., python/ray/air/util/tensor_extensions/arrow.py), it would be better to specify the exact path for this module.
Suggested change
| # NOTE: We provide these as aliases to maintain compatibility with older version | |
| # of Arrow `PyExtensionType` that relies on picked class references that | |
| # reference `ray.air.util.{tensor|object}_extensions.arrow.*` classes | |
| # NOTE: We provide these as aliases to maintain compatibility with older versions | |
| # of Arrow `PyExtensionType` that relies on picked class references that | |
| # reference `ray.air.util.object_extensions.arrow.*` classes |
matthewdeng
approved these changes
Jan 3, 2026
AYou0207
pushed a commit
to AYou0207/ray
that referenced
this pull request
Jan 13, 2026
… to fix deserialization of existing datasets (ray-project#59828) ## Description Follow-up for ray-project#59818 1. Fixing serde for `ArrowPythonObjectType` 2. Missing `__init__.py` files making packages omitted at build time ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #59818
ArrowPythonObjectType__init__.pyfiles making packages omitted at build timeRelated issues
Additional information