[Data] Expose logical operators via package exports#60297
Merged
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a nice refactoring that exposes logical operators via a centralized package entry point, which improves code structure and maintainability. The changes are consistent, adding __all__ to operator modules and updating imports throughout the codebase. The dynamic import mechanism in __init__.py is a clean way to achieve this. I have one suggestion to make the dynamic import more robust against future changes.
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Contributor
Author
|
@bveeramani PTAL |
ray-gardener
Bot
added
data
bveeramani
approved these changes
Jan 26, 2026
Member
|
nice ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal:
Make
ray.data._internal.logical.operators a package entry point with short imports and alphabetized__all__.Changes:
Add/complete all in operator modules and re-export via
__init__.py.Update imports to from
ray.data._internal.logical.operators import ....Keep intra-operator dependencies using module paths to avoid cycles.
Related issues
Related to #60204
Additional information