[Data][expr] Add cast method for type conversion in expressions#60695
Merged
Conversation
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a cast method for expressions, enabling type conversions within Ray Data expressions. The implementation is well-structured, leveraging a helper function _normalize_cast_target_type to handle various type representations and creating a UDF for the casting operation. The accompanying tests are comprehensive, covering basic conversions, edge cases like safe casting, and error handling for invalid types.
I have one suggestion to simplify the type normalization logic for improved maintainability. Overall, this is a great addition that enhances the expressiveness of Ray Data.
daiping8
changed the title
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ray-gardener
Bot
added
data
Contributor
|
Thanks for the contribution. Left a few comments. |
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Contributor
Author
Thank you for your suggestion. All suggestions have been adopted. |
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
daiping8
changed the title
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Signed-off-by: daiping8 <dai.ping88@zte.com.cn>
Contributor
Author
|
@goutamvenkat-anyscale All suggestions have been applied. CI test has passed. Please review again, thank you. |
alexeykudinkin
approved these changes
Feb 9, 2026
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
…project#60695) ## Description - Implemented a new `cast` method in the `Expr` class to allow casting of expressions to specified data types using PyArrow. - Added comprehensive tests for the `cast` method covering basic conversions, use cases, safe mode, and error handling for invalid types. ## Related issues Closes ray-project#60644 --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: 金嘉淇10353800 <jin.jiaqi@zte.com.cn> Co-authored-by: 金嘉淇10353800 <jin.jiaqi@zte.com.cn> Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
…project#60695) ## Description - Implemented a new `cast` method in the `Expr` class to allow casting of expressions to specified data types using PyArrow. - Added comprehensive tests for the `cast` method covering basic conversions, use cases, safe mode, and error handling for invalid types. ## Related issues Closes ray-project#60644 --------- Signed-off-by: daiping8 <dai.ping88@zte.com.cn> Signed-off-by: 金嘉淇10353800 <jin.jiaqi@zte.com.cn> Co-authored-by: 金嘉淇10353800 <jin.jiaqi@zte.com.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
castmethod in theExprclass to allow casting of expressions to specified data types using PyArrow.castmethod covering basic conversions, use cases, safe mode, and error handling for invalid types.Related issues
Closes #60644