[Data] Fix AliasExpr structural equality to respect rename flag#60711
Merged
alexeykudinkin merged 7 commits intoFeb 6, 2026
Merged
Conversation
This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename Signed-off-by: slfan1989 <slfan1989@apache.org>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in AliasExpr.structurally_equals where the _is_rename flag was compared against itself instead of the other expression's flag. This ensures that structural equality checks for AliasExpr are accurate, which is important for logical optimizations. The change is correct and addresses the issue effectively.
To prevent future regressions, I recommend adding a unit test to cover this specific case. A test comparing an AliasExpr created with alias() (_is_rename=False) and one created with _rename() (_is_rename=True) would have caught this bug and will help safeguard the fix.
ray-gardener
Bot
added
data
Contributor
|
Thanks. Can you please add a unit test? |
Contributor
Author
Thanks for your message — I’ll add unit tests. |
This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename Signed-off-by: slfan1989 <slfan1989@apache.org>
Contributor
Author
|
@goutamvenkat-anyscale @bveeramani I've added the new unit test. Could you please take another look at the PR when you have a moment? Thank you so much! |
| from ray.data.expressions import col | ||
|
|
||
|
|
||
| def test_alias_structurally_equals_respects_rename_flag(): |
Contributor
There was a problem hiding this comment.
You can actually move this into python/ray/data/tests/unit/expressions/test_core.py . There's already a class for AliasExpr
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing the code — I’ve made the changes based on your suggestions.
This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename Signed-off-by: slfan1989 <slfan1989@apache.org>
Contributor
Author
|
@goutamvenkat-anyscale Thanks so much for reviewing the code! |
alexeykudinkin
approved these changes
Feb 6, 2026
Contributor
Author
|
@goutamvenkat-anyscale @alexeykudinkin Thanks a lot for helping review the code! |
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…project#60711) ## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com> Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…project#60711) ## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com>
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
…project#60711) ## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
…project#60711) ## Description This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown). Main changes: Correct comparison of _is_rename against other._is_rename ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. <!-- BUGBOT_STATUS --><sup><a href="https://cursor.com/dashboard?tab=bugbot">Cursor Bugbot</a> is reviewing your changes for commit <u>9a399ac</u></sup><!-- /BUGBOT_STATUS --> --------- Signed-off-by: slfan1989 <slfan1989@apache.org> Co-authored-by: Goutam <goutam@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in AliasExpr.structurally_equals where the rename marker was always treated as equal, causing incorrect structural equality results. This could affect logical optimization rules that rely on accurate expression equivalence (e.g., projection pushdown).
Main changes:
Correct comparison of _is_rename against other._is_rename
Related issues
Additional information
Cursor Bugbot is reviewing your changes for commit 9a399ac