[Data] [Docs] Add missing MOD operation documentation in Operation enum#60803
Merged
richardliaw merged 2 commits intoFeb 6, 2026
Merged
Conversation
The MOD (modulo) operation was already defined in the Operation enum but was missing from the class-level docstring. This commit adds the documentation for the MOD operation to improve API documentation completeness. Signed-off-by: slfan1989 <slfan1989@apache.org>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing documentation for the MOD (modulo) operation to the Operation enum's docstring. The change is straightforward and improves the completeness of the API documentation. While this PR focuses on the enum docstring, a related improvement would be to fix a small typo in the docstrings for the __mod__ and __rmod__ methods in the Expr class, changing 'Modulation operator' to 'Modulo operator' for consistency.
Contributor
Author
|
@alexeykudinkin Could you please review this documentation fix? Thanks! This minor issue was introduced in #55920. |
goutamvenkat-anyscale
approved these changes
Feb 6, 2026
goutamvenkat-anyscale
added
data
Contributor
Author
|
@goutamvenkat-anyscale @richardliaw Thanks a lot for reviewing the code! |
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…um (ray-project#60803) Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
tiennguyentony
pushed a commit
to tiennguyentony/ray
that referenced
this pull request
Feb 7, 2026
…um (ray-project#60803) Signed-off-by: tiennguyentony <46289799+tiennguyentony@users.noreply.github.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
…um (#60803) Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Feb 9, 2026
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
…um (ray-project#60803) Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing documentation for the
MOD(modulo) operation in theOperationenum's docstring. TheMODoperation was already implemented in the enum (line 74) and fully functional, but was accidentally omitted from the class-level docstring that lists all available operations.This PR improves API documentation completeness by documenting the modulo operation alongside other arithmetic operations like
ADD,SUB,MUL,DIV, andFLOORDIV.Related issues
N/A - Documentation improvement only
Additional information
MOD: Modulo operation (%)to theAttributessection of theOperationenum docstring