Skip to content

[data] add checkpoint data load method on LoadCheckpointCallback#60951

Merged
justinvyu merged 3 commits into
masterfrom
tiny_ckpt_callback_update
Feb 12, 2026
Merged

[data] add checkpoint data load method on LoadCheckpointCallback#60951
justinvyu merged 3 commits into
masterfrom
tiny_ckpt_callback_update

Conversation

@justinvyu

@justinvyu justinvyu commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Description

Update the LoadCheckpointCallback to have an explicit method for loading the checkpoint block, for testing and patchability/subclassing purposes. Also update some imports from the ray.data.checkpoint alias instead of from the full path.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu requested a review from a team as a code owner February 11, 2026 00:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a small but effective refactoring within the LoadCheckpointCallback class. The logic for loading checkpoint data has been extracted into a new protected method, _load_checkpoint_data. This change improves the code's structure by increasing modularity, which directly supports the stated goals of easier testing and subclassing. The implementation is clean and correct. Overall, this is a good improvement to the codebase.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu changed the title [data] small update on load checkpoint callback Feb 12, 2026
@justinvyu justinvyu enabled auto-merge (squash) February 12, 2026 18:20
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label Feb 12, 2026
@justinvyu justinvyu merged commit e0c6da4 into master Feb 12, 2026
8 checks passed
@justinvyu justinvyu deleted the tiny_ckpt_callback_update branch February 12, 2026 19:01
ans9868 pushed a commit to ans9868/ray that referenced this pull request Feb 18, 2026
…-project#60951)

Update the LoadCheckpointCallback to have an explicit method for loading
the checkpoint block, for testing and patchability/subclassing purposes.
Also update some imports from the `ray.data.checkpoint` alias instead of
from the full path.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab pushed a commit to kunling-anyscale/ray that referenced this pull request Feb 20, 2026
…-project#60951)

Update the LoadCheckpointCallback to have an explicit method for loading
the checkpoint block, for testing and patchability/subclassing purposes.
Also update some imports from the `ray.data.checkpoint` alias instead of
from the full path.

---------

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

2 participants