[Serve] Move fcntl import in haproxy.py to function scope for Windows compat by eicherseiji · Pull Request #60955 · ray-project/ray

eicherseiji · 2026-02-11T01:28:28Z

Why are these changes needed?

The top-level import fcntl in haproxy.py causes //python/ray/serve:doctest to fail on Windows with ModuleNotFoundError: No module named 'fcntl'. fcntl is Unix-only, and HAProxy is not supported on Windows, but the doctest target still collects this file during pytest collection.

Moving the import to function scope matches the pattern used by other files in the repo (e.g. cluster_init.py) and avoids the import error during collection.

Fixes postmerge Windows test failure: https://buildkite.com/ray-project/postmerge/builds/15965#019c49ac-39cf-4733-83d6-9703941281c1

Related issue number

N/A

Checks

I've signed all my commits
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

… compat The top-level `import fcntl` in haproxy.py causes doctest collection to fail on Windows with `ModuleNotFoundError: No module named 'fcntl'`. fcntl is Unix-only and HAProxy is not supported on Windows, but the doctest target still collects this file. Moving the import to function scope (matching the pattern used by cluster_init.py) avoids the import error during collection. Fixes postmerge Windows test failure in //python/ray/serve:doctest. Signed-off-by: Seiji Eicher <seiji@anyscale.com>

gemini-code-assist

Code Review

This pull request moves the fcntl import in haproxy.py to be function-scoped. This is a good change to improve Windows compatibility, as fcntl is a Unix-only module. By importing it only within the function where it's used, it avoids ModuleNotFoundError during test collection on Windows. The change is correct, follows existing patterns in the repository, and effectively resolves the described issue. I have no further comments.

Signed-off-by: Seiji Eicher <seiji@anyscale.com>

gemini-code-assist · 2026-02-11T02:38:39Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

abrarsheikh · 2026-02-11T02:40:11Z

            # This is important in test environments where multiple nodes may run
            # on the same machine
            with open(self.config_file_path, "w") as f:
+                import fcntl


why does moving import here work?

I think doctest just needs to import the file to search for >>> tests. If we import fcntl lazily, we can avoid the ImportError, since haproxy.py anyway does not define any doctest. I am running the test to confirm

I can add a comment

Revisit Windows compatibility for fcntl

eicherseiji · 2026-02-11T02:46:54Z

Running test: https://buildkite.com/ray-project/premerge/builds/59968

Signed-off-by: Seiji Eicher <seiji@anyscale.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

cursor · 2026-02-11T03:04:51Z

    commands:
      - bash ci/ray_ci/windows/install_tools.sh
-      - bazel run //ci/ray_ci:test_in_docker -- //python/ray/serve/... serve
+      - bazel run //ci/ray_ci:test_in_docker -- //python/ray/serve:doctest serve


Windows serve CI job drops most test coverage

High Severity

The test target was narrowed from //python/ray/serve/... (all serve tests) to //python/ray/serve:doctest (only the doctest target). Previously this job ran all serve tests on Windows except those tagged no_windows or use_all_core_windows, with parallelism. Now only the single doctest target runs. The "enormous tests" job only covers use_all_core_windows-tagged tests, so all other non-doctest Windows serve tests are now entirely uncovered in CI. The PR author's comment about the build not picking up a test suggests this is unfinished.

This reverts commit 15a0226. Signed-off-by: Seiji Eicher <seiji@anyscale.com>

This reverts commit 529d104. Signed-off-by: Seiji Eicher <seiji@anyscale.com>

…seiji/ray into fix-haproxy-fcntl-windows

eicherseiji · 2026-02-11T18:57:57Z

Running: https://buildkite.com/ray-project/microcheck/builds/38141

eicherseiji · 2026-02-12T18:46:17Z

Trying again: https://buildkite.com/ray-project/microcheck/builds/38252

eicherseiji · 2026-02-14T08:06:12Z

Third times the charm: https://buildkite.com/ray-project/postmerge/builds/16064

eicherseiji · 2026-02-15T00:30:56Z

Windows //python/ray/serve:doctest passed in https://buildkite.com/ray-project/postmerge/builds/16064#019c5b30-be86-4305-ac0e-0b6a7e2d4fad

… compat (ray-project#60955) ## Why are these changes needed? The top-level `import fcntl` in `haproxy.py` causes `//python/ray/serve:doctest` to fail on Windows with `ModuleNotFoundError: No module named 'fcntl'`. `fcntl` is Unix-only, and HAProxy is not supported on Windows, but the doctest target still collects this file during pytest collection. Moving the import to function scope matches the pattern used by other files in the repo (e.g. `cluster_init.py`) and avoids the import error during collection. Fixes postmerge Windows test failure: https://buildkite.com/ray-project/postmerge/builds/15965#019c49ac-39cf-4733-83d6-9703941281c1 ## Related issue number N/A ## Checks - [x] I've signed all my commits - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for <https://docs.ray.io/en/master/>. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>

… compat (ray-project#60955) ## Why are these changes needed? The top-level `import fcntl` in `haproxy.py` causes `//python/ray/serve:doctest` to fail on Windows with `ModuleNotFoundError: No module named 'fcntl'`. `fcntl` is Unix-only, and HAProxy is not supported on Windows, but the doctest target still collects this file during pytest collection. Moving the import to function scope matches the pattern used by other files in the repo (e.g. `cluster_init.py`) and avoids the import error during collection. Fixes postmerge Windows test failure: https://buildkite.com/ray-project/postmerge/builds/15965#019c49ac-39cf-4733-83d6-9703941281c1 ## Related issue number N/A ## Checks - [x] I've signed all my commits - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for <https://docs.ray.io/en/master/>. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Seiji Eicher <seiji@anyscale.com>

eicherseiji added the go add ONLY when ready to merge, run all tests label Feb 11, 2026

gemini-code-assist Bot reviewed Feb 11, 2026

View reviewed changes

ci: unblock windows serve flaky tests from premerge

529d104

Signed-off-by: Seiji Eicher <seiji@anyscale.com>

abrarsheikh marked this pull request as ready for review February 11, 2026 02:38

abrarsheikh requested a review from a team as a code owner February 11, 2026 02:38

abrarsheikh reviewed Feb 11, 2026

View reviewed changes

ci: target windows serve doctest for premerge validation

15a0226

Signed-off-by: Seiji Eicher <seiji@anyscale.com>

cursor Bot reviewed Feb 11, 2026

View reviewed changes

eicherseiji marked this pull request as draft February 11, 2026 03:15

eicherseiji and others added 4 commits February 10, 2026 19:53

Merge branch 'master' into fix-haproxy-fcntl-windows

6b33dd3

Revert "ci: target windows serve doctest for premerge validation"

270a0ee

This reverts commit 15a0226. Signed-off-by: Seiji Eicher <seiji@anyscale.com>

Revert "ci: unblock windows serve flaky tests from premerge"

d26c039

This reverts commit 529d104. Signed-off-by: Seiji Eicher <seiji@anyscale.com>

Merge branch 'fix-haproxy-fcntl-windows' of https://github.com/eicher…

63b2aa9

…seiji/ray into fix-haproxy-fcntl-windows

Merge branch 'master' into fix-haproxy-fcntl-windows

0f4a69e

Merge branch 'master' into fix-haproxy-fcntl-windows

16981be

eicherseiji marked this pull request as ready for review February 15, 2026 03:04

abrarsheikh approved these changes Feb 15, 2026

View reviewed changes

abrarsheikh merged commit db045c4 into ray-project:master Feb 15, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Serve] Move fcntl import in haproxy.py to function scope for Windows compat#60955

[Serve] Move fcntl import in haproxy.py to function scope for Windows compat#60955
abrarsheikh merged 9 commits into
ray-project:masterfrom
eicherseiji:fix-haproxy-fcntl-windows

eicherseiji commented Feb 11, 2026

gemini-code-assist Bot left a comment

gemini-code-assist Bot commented Feb 11, 2026

abrarsheikh Feb 11, 2026

eicherseiji Feb 11, 2026 •

edited

Loading

eicherseiji Feb 11, 2026

eicherseiji commented Feb 11, 2026 •

edited

Loading

cursor Bot left a comment

cursor Bot Feb 11, 2026

eicherseiji commented Feb 11, 2026

eicherseiji commented Feb 12, 2026

eicherseiji commented Feb 14, 2026

eicherseiji commented Feb 15, 2026

Uh oh!

Labels

2 participants

Uh oh!

Conversation

eicherseiji commented Feb 11, 2026

Why are these changes needed?

Related issue number

Checks

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

gemini-code-assist Bot commented Feb 11, 2026

abrarsheikh Feb 11, 2026

Choose a reason for hiding this comment

eicherseiji Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

eicherseiji Feb 11, 2026

Choose a reason for hiding this comment

eicherseiji commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

cursor Bot Feb 11, 2026

Choose a reason for hiding this comment

Windows serve CI job drops most test coverage

eicherseiji commented Feb 11, 2026

eicherseiji commented Feb 12, 2026

eicherseiji commented Feb 14, 2026

eicherseiji commented Feb 15, 2026

Uh oh!

Labels

2 participants

eicherseiji Feb 11, 2026 •

edited

Loading

eicherseiji commented Feb 11, 2026 •

edited

Loading