[Data] Fixed min_scheduling_resources to fallback to incremental_resource_usage by default#60997
Merged
Conversation
…al_resources` Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default behavior of min_scheduling_resources in PhysicalOperator to fall back to incremental_resource_usage(). This is a sensible default. However, the explicit override for HashShufflingOperatorBase is now redundant due to this change in the base class and can be removed to avoid code duplication.
Comment on lines
+1050
to
+1052
| def min_scheduling_resources(self) -> ExecutionResources: | ||
| return self.incremental_resource_usage() | ||
|
|
Contributor
There was a problem hiding this comment.
This override of min_scheduling_resources is now redundant. The base class PhysicalOperator is also being updated in this pull request to return self.incremental_resource_usage(). This method can be removed from HashShufflingOperatorBase to avoid unnecessary code duplication.
bveeramani
approved these changes
Feb 12, 2026
alexeykudinkin
added a commit
that referenced
this pull request
Feb 12, 2026
…urce_usage by default (#60997) ## Description - Fixed min_scheduling_resources to fallback to incremental_resource_usage by default - Explicitly overridden for `HashShufflingOperatorBase` ## Related issues > Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
ayushk7102
pushed a commit
to ayushk7102/ray
that referenced
this pull request
Feb 12, 2026
…urce_usage by default (ray-project#60997) ## Description - Fixed min_scheduling_resources to fallback to incremental_resource_usage by default - Explicitly overridden for `HashShufflingOperatorBase` ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: Ayush Kumar <ayush.kumar@anyscale.com>
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
…urce_usage by default (ray-project#60997) ## Description - Fixed min_scheduling_resources to fallback to incremental_resource_usage by default - Explicitly overridden for `HashShufflingOperatorBase` ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
…urce_usage by default (ray-project#60997) ## Description - Fixed min_scheduling_resources to fallback to incremental_resource_usage by default - Explicitly overridden for `HashShufflingOperatorBase` ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HashShufflingOperatorBaseRelated issues
Additional information