Revert "[data] continue grabbing task state until response is not Non…e (#60592)" - #61064
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that introduced a performance regression in the hanging task detector. The regression was caused by repeatedly calling ray.util.state.get_task for hanging tasks on every detection cycle.
The changes correctly fix this issue by moving the call to ray.util.state.get_task to be conditional, only executing when a task is first identified as potentially hanging or when its output status changes. This significantly reduces the number of API calls. The associated helper function get_latest_state_for_task has been removed, and the test has been updated to match the modified log message format.
The changes look good and effectively address the regression. I have no further comments.
codope
approved these changes
Feb 14, 2026
alexeykudinkin
enabled auto-merge (squash)
February 14, 2026 06:51
aslonnie
added a commit
to anyscale/ray
that referenced
this pull request
Feb 14, 2026
revert ray-project#60592, cherrypick ray-project#61064 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
disabled auto-merge
February 14, 2026 09:17
ans9868
pushed a commit
to ans9868/ray
that referenced
this pull request
Feb 18, 2026
……e (ray-project#60592)" (ray-project#61064) This reverts commit 685d6d9. This is causing a sever regression by repeatedly hitting `ray.util.state.get_task` without any backoff on failures. <img width="1920" height="880" alt="Screenshot 2026-02-13 at 10 42 24 PM" src="https://github.com/user-attachments/assets/2a99ea4a-5e88-434d-aa4d-9a51a91ca832" /> ## Description > Briefly describe what this PR accomplishes and why it's needed. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
Aydin-ab
pushed a commit
to kunling-anyscale/ray
that referenced
this pull request
Feb 20, 2026
……e (ray-project#60592)" (ray-project#61064) This reverts commit 685d6d9. This is causing a sever regression by repeatedly hitting `ray.util.state.get_task` without any backoff on failures. <img width="1920" height="880" alt="Screenshot 2026-02-13 at 10 42 24 PM" src="https://github.com/user-attachments/assets/2a99ea4a-5e88-434d-aa4d-9a51a91ca832" /> ## Description > Briefly describe what this PR accomplishes and why it's needed. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
iamjustinhsu
added a commit
to iamjustinhsu/ray
that referenced
this pull request
Mar 10, 2026
… not Non…e (ray-project#60592)" (ray-project#61064)" This reverts commit feca476.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 685d6d9.
This is causing a sever regression by repeatedly hitting
ray.util.state.get_taskwithout any backoff on failures.Description
Related issues
Additional information