[Data] Move resource budget Prometheus gauges to ExecutionCallback#62209
Merged
bveeramani merged 6 commits intoApr 2, 2026
Merged
Conversation
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the resource allocation metrics logic by moving it from the StreamingExecutor into a dedicated ResourceAllocatorPrometheusCallback. The new callback handles the initialization and updating of Prometheus gauges for CPU, GPU, memory, and object store memory budgets, as well as the maximum bytes to read. The StreamingExecutor now includes this callback by default and extends its callback list when additional ones are provided during execution. I have no feedback to provide.
ray-gardener
Bot
added
data
bveeramani
reviewed
Mar 30, 2026
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
bveeramani
approved these changes
Apr 1, 2026
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
bveeramani
approved these changes
Apr 1, 2026
mancfactor
pushed a commit
to mancfactor/ray
that referenced
this pull request
Apr 2, 2026
…ay-project#62209) ### Description This PR moves out responsibility of tracking Prometheus metrics for resource budgets into a new class ResourceAllocatorPrometheusCallback. This is in accordance with single responsibility principle. Closes ray-project#60269 --------- Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com> Signed-off-by: Frank Mancina <fmancina@haproxy.com>
Lucas61000
pushed a commit
to Lucas61000/ray
that referenced
this pull request
May 15, 2026
…ay-project#62209) ### Description This PR moves out responsibility of tracking Prometheus metrics for resource budgets into a new class ResourceAllocatorPrometheusCallback. This is in accordance with single responsibility principle. Closes ray-project#60269 --------- Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves out responsibility of tracking Prometheus metrics for resource budgets into a new class ResourceAllocatorPrometheusCallback.
This is in accordance with single responsibility principle.
Closes #60269