Skip to content

[Data] Autoscaling Coordinator - Make log traceback configurable#62210

Merged
goutamvenkat-anyscale merged 4 commits into
ray-project:masterfrom
goutamvenkat-anyscale:goutam/log_traceback_env_var
Mar 31, 2026
Merged

[Data] Autoscaling Coordinator - Make log traceback configurable#62210
goutamvenkat-anyscale merged 4 commits into
ray-project:masterfrom
goutamvenkat-anyscale:goutam/log_traceback_env_var

Conversation

@goutamvenkat-anyscale

Copy link
Copy Markdown
Contributor

Description

Make logging of traceback configurable by env var for better logging UX

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

Signed-off-by: Goutam <goutam@anyscale.com>
@goutamvenkat-anyscale goutamvenkat-anyscale requested a review from a team as a code owner March 30, 2026 19:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the RAY_DATA_AUTOSCALING_COORDINATOR_LOG_TRACEBACK environment variable to conditionally control traceback logging in the autoscaling coordinator, alongside minor formatting updates to lambda functions and method signatures. The review feedback recommends refactoring the environment variable lookup into a module-level constant to enhance performance by avoiding redundant calls and to align with the file's established configuration patterns.

Comment thread python/ray/data/_internal/cluster_autoscaler/default_autoscaling_coordinator.py Outdated
Signed-off-by: Goutam <goutam@anyscale.com>
@ray-gardener ray-gardener Bot added the data Ray Data-related issues label Mar 30, 2026
@goutamvenkat-anyscale goutamvenkat-anyscale added the go add ONLY when ready to merge, run all tests label Mar 30, 2026
@goutamvenkat-anyscale goutamvenkat-anyscale enabled auto-merge (squash) March 31, 2026 16:32
@github-actions github-actions Bot disabled auto-merge March 31, 2026 16:32
@goutamvenkat-anyscale goutamvenkat-anyscale enabled auto-merge (squash) March 31, 2026 22:49
@goutamvenkat-anyscale goutamvenkat-anyscale merged commit b165ee7 into ray-project:master Mar 31, 2026
7 checks passed
mancfactor pushed a commit to mancfactor/ray that referenced this pull request Apr 2, 2026
…-project#62210)

## Description
Make logging of traceback configurable by env var for better logging UX

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

---------

Signed-off-by: Goutam <goutam@anyscale.com>
Signed-off-by: Frank Mancina <fmancina@haproxy.com>
Lucas61000 pushed a commit to Lucas61000/ray that referenced this pull request May 15, 2026
…-project#62210)

## Description
Make logging of traceback configurable by env var for better logging UX

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

---------

Signed-off-by: Goutam <goutam@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

2 participants