Skip to content

[Core] add dependency info to taskspec debugstring#62316

Merged
edoakes merged 2 commits into
ray-project:masterfrom
laysfire:add_dependency_info_to_debugstring
Apr 3, 2026
Merged

[Core] add dependency info to taskspec debugstring#62316
edoakes merged 2 commits into
ray-project:masterfrom
laysfire:add_dependency_info_to_debugstring

Conversation

@laysfire

@laysfire laysfire commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Description

To improve troubleshooting, add dependency information to the debug string in the task specification.

Signed-off-by: yifan.xie <xyfabcd@163.com>
@laysfire laysfire requested a review from a team as a code owner April 3, 2026 03:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TaskSpecification::DebugString() method to include task dependencies in the debug output. The feedback suggests refactoring the implementation to reuse the existing GetDependencyIds() method, which would reduce code duplication and improve the formatting of the output string by eliminating trailing commas.

Comment thread src/ray/common/task/task_spec.cc
Signed-off-by: yifan.xie <xyfabcd@163.com>
@ray-gardener ray-gardener Bot added core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels Apr 3, 2026
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Apr 3, 2026
@edoakes edoakes enabled auto-merge (squash) April 3, 2026 12:37
@edoakes edoakes merged commit 249c948 into ray-project:master Apr 3, 2026
8 of 9 checks passed
Lucas61000 pushed a commit to Lucas61000/ray that referenced this pull request May 15, 2026
To improve troubleshooting, add dependency information to the debug
string in the task specification.

---------

Signed-off-by: yifan.xie <xyfabcd@163.com>
@laysfire laysfire deleted the add_dependency_info_to_debugstring branch May 27, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

2 participants