Skip to content

[image] add apt-get upgrade for slim bases#62666

Merged
aslonnie merged 1 commit into
ray-project:masterfrom
anyscale:lonnie-260416-slimup
Apr 16, 2026
Merged

[image] add apt-get upgrade for slim bases#62666
aslonnie merged 1 commit into
ray-project:masterfrom
anyscale:lonnie-260416-slimup

Conversation

@aslonnie

Copy link
Copy Markdown
Contributor

to pick up latest ubuntu apt source updates

@aslonnie aslonnie requested a review from a team April 16, 2026 16:59
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Apr 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 8af6258e1faf5c74eb4ef63426bbacf13b0968d3. Configure here.

Comment thread docker/base-slim/Dockerfile

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces apt-get upgrade -y into the Dockerfile. The review feedback highlights that this practice is discouraged due to its impact on build reproducibility and image size. Additionally, the second occurrence lacks the DEBIAN_FRONTEND=noninteractive setting, which may cause the build process to hang during package configuration.

Comment thread docker/base-slim/Dockerfile
Comment thread docker/base-slim/Dockerfile
to pick up latest ubuntu apt source updates

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie force-pushed the lonnie-260416-slimup branch from 8af6258 to 12a614d Compare April 16, 2026 17:12
@aslonnie aslonnie merged commit 4c9a9d8 into ray-project:master Apr 16, 2026
6 checks passed
aslonnie added a commit to anyscale/ray that referenced this pull request Apr 17, 2026
add apt-get update for slim base

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
aslonnie added a commit that referenced this pull request Apr 17, 2026
add apt-get update for slim base

Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
HLDKNotFound pushed a commit to chichic21039/ray that referenced this pull request Apr 22, 2026
to pick up latest ubuntu apt source updates

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Lucas61000 pushed a commit to Lucas61000/ray that referenced this pull request May 15, 2026
to pick up latest ubuntu apt source updates

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

3 participants