[ci] fix BUILDKITE_BAZEL_CACHE_URL scope in manylinux-retag - #62723
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the manylinux-retag.Dockerfile by moving the BUILDKITE_BAZEL_CACHE_URL argument definition to after the FROM instruction, ensuring it is available during the build stage. A review comment suggests that baking this value into the .bazelrc at build-time might conflict with runtime environment variables, recommending a shift to runtime configuration to ensure the environment variable is correctly honored.
ARG BUILDKITE_BAZEL_CACHE_URL was declared before FROM, so it was out of scope for the RUN heredoc that writes /home/forge/.bazelrc Signed-off-by: andrew <andrew@anyscale.com>
andrew-anyscale
force-pushed
the
andrewpollack/fix-manylinux-retag
branch
from
April 17, 2026 18:39
4dc84d0 to
829d147
Compare
aslonnie
approved these changes
Apr 17, 2026
aslonnie
enabled auto-merge (squash)
April 19, 2026 18:33
aslonnie
self-requested a review
April 19, 2026 18:33
HLDKNotFound
pushed a commit
to chichic21039/ray
that referenced
this pull request
Apr 22, 2026
…ect#62723) ARG BUILDKITE_BAZEL_CACHE_URL was declared before FROM, so it was out of scope for the RUN heredoc that writes /home/forge/.bazelrc Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Lucas61000
pushed a commit
to Lucas61000/ray
that referenced
this pull request
May 15, 2026
…ect#62723) ARG BUILDKITE_BAZEL_CACHE_URL was declared before FROM, so it was out of scope for the RUN heredoc that writes /home/forge/.bazelrc Signed-off-by: andrew <andrew@anyscale.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARG BUILDKITE_BAZEL_CACHE_URL was declared before FROM, so it was out of scope for the RUN heredoc that writes /home/forge/.bazelrc
Description
Related issues
Additional information