cherrypick #62758 - #62759
Merged
aslonnie merged 1 commit intoApr 19, 2026
Merged
cherrypick #62758#62759
Conversation
declare ARG below FROM and explicitly re-set ENV from the ARG value, so the rayturbo build_arg takes effect in the RUN and /home/forge/.bazelrc is written with the correct cache URL. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the manylinux-retag.Dockerfile by moving the BUILDKITE_BAZEL_CACHE_URL argument after the FROM instruction and adding it as an environment variable. Feedback suggests removing the ENV instruction because it unnecessarily persists potentially sensitive information in the image metadata and is redundant since the variable is already provided at runtime.
Comment on lines
+13
to
+14
| ARG BUILDKITE_BAZEL_CACHE_URL | ||
| ENV BUILDKITE_BAZEL_CACHE_URL=${BUILDKITE_BAZEL_CACHE_URL} |
Contributor
There was a problem hiding this comment.
Using ENV to store BUILDKITE_BAZEL_CACHE_URL is redundant and potentially insecure.
- Security:
ENVvariables persist in the final image and are visible viadocker inspect. If this URL contains sensitive information (e.g., credentials or tokens), it will be exposed in the image metadata. - Redundancy: The
ARGinstruction is sufficient to make the variable available to theRUNblock during the build process. Additionally,ci/ray_ci/container.pyalready passes this variable at runtime via the--envflag, so setting it as a defaultENVin the Dockerfile is unnecessary.
It is recommended to use only ARG for build-time configuration that doesn't need to persist in the image environment.
ARG BUILDKITE_BAZEL_CACHE_URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declare ARG below FROM and explicitly re-set ENV from the ARG value, so the rayturbo build_arg takes effect in the RUN and /home/forge/.bazelrc is written with the correct cache URL.