[Docker] Update TPU Docker image base deps#63006
Conversation
|
This is what the |
There was a problem hiding this comment.
Code Review
This pull request updates the dependency configuration for TPU environments, including switching to --find-links in the depset configuration and expanding the requirements_tpu.in file with necessary JAX ecosystem packages. Feedback was provided regarding a potential version typo for JAX and the need for a lower bound on the numpy version constraint to ensure compatibility.
|
For some more context: We have a custom python dependency management tool called raydepsets. Its a uv wrapper that uses configs to determine requirements, constraints for rays dependencies and expands them for different workloads/use cases |
Sounds good, ran the depset file and changed it to a lower bound in 9346d34, Now this version gets installed: |
|
@elliot-barn should be updated now accordingly, I added a python dependency check in the TPU requirements file since the JAX version for Ironwood TPU requires Python |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit d633d6ad0093bcd9d2d87d3189af9ec6bd7bacdd. Configure here.
|
had to change the tpu image to build from in d633d6a |
|
@elliot-barn wondering if there's any concern with the change here: #63006 (comment), if not I'll go ahead and merge this. Thanks again!! |
This looks great can you fix the merge conflicts and i can merge for you |
fa3101f to
41c0e53
Compare
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
… python version Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
41c0e53 to
6b584ea
Compare
Sounds good thanks!! rebased on master and re-ran the build depsets script |
## Description This PR resolves ray-project#62402 by ensuring a `jax[tpu]` version >= `0.8.2` is installed. More context for why this change is necessary is provided in the linked issue. This PR also adds several lightweight packages that are commonly used with `jax[tpu]` and `libtpu`. The list of updated dependencies is based on common packages seen in JAX-based frameworks like: [Maxtext](https://github.com/AI-Hypercomputer/maxtext/blob/main/src/dependencies/requirements/requirements.txt) and [tpu_inference](https://github.com/vllm-project/tpu-inference/blob/main/requirements.txt). ## Related issues ray-project#62402 --------- Signed-off-by: ryanaoleary <ryanaoleary@google.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Description
This PR resolves #62402 by ensuring a
jax[tpu]version >=0.8.2is installed. More context for why this change is necessary is provided in the linked issue.This PR also adds several lightweight packages that are commonly used with
jax[tpu]andlibtpu. The list of updated dependencies is based on common packages seen in JAX-based frameworks like: Maxtext and tpu_inference.Related issues
#62402