[Serve] Include ingress_request_router.lua.tmpl in package_data#63145
Merged
Conversation
Prep for the HAProxy ingress-request-router Lua template introduced in ray-project#62669. The template is loaded at runtime by `ray.serve._private.haproxy` (via `Path(__file__).parent / "ingress_request_router.lua.tmpl"`), so it must be packaged into the wheel. The pattern matches zero files until ray-project#62669 lands; setuptools accepts that without error. Splitting this out so the package_data change can be reviewed independently of the HAProxy/Lua logic. Signed-off-by: Seiji Eicher <seiji@anyscale.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates python/setup.py to include a specific Lua template file in the package data. The reviewer suggests using a glob pattern instead to ensure consistency with other entries and to automatically include any future templates in that directory.
| "includes/*.pxd", | ||
| "*.pxd", | ||
| "llm/_internal/serve/config_generator/base_configs/templates/*.yaml", | ||
| "serve/_private/ingress_request_router.lua.tmpl", |
Contributor
There was a problem hiding this comment.
For consistency with the other entries in package_data (lines 843-845) and to align with the description of this as a "pattern", consider using a glob. This also ensures that any future Lua templates added to this directory are automatically included without requiring further changes to setup.py.
Suggested change
| "serve/_private/ingress_request_router.lua.tmpl", | |
| "serve/_private/*.lua.tmpl", |
4 tasks
aslonnie
approved these changes
May 5, 2026
Contributor
Author
|
@aslonnie okay to force merge? failing due to |
Lucas61000
pushed a commit
to Lucas61000/ray
that referenced
this pull request
May 15, 2026
…project#63145) Prep for the HAProxy ingress-request-router Lua template introduced in ray-project#62669. The template is loaded at runtime by `ray.serve._private.haproxy` (via `Path(__file__).parent / "ingress_request_router.lua.tmpl"`), so it must be packaged into the wheel. Splitting this out per @aslonnie's review feedback on ray-project#62669 so the `package_data` change can be reviewed independently of the HAProxy/Lua logic. The pattern matches zero files until ray-project#62669 lands; setuptools accepts that without error. Signed-off-by: Seiji Eicher <seiji@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prep for the HAProxy ingress-request-router Lua template introduced in #62669. The template is loaded at runtime by
ray.serve._private.haproxy(viaPath(__file__).parent / "ingress_request_router.lua.tmpl"), so it must be packaged into the wheel.Splitting this out per @aslonnie's review feedback on #62669 so the
package_datachange can be reviewed independently of the HAProxy/Lua logic.The pattern matches zero files until #62669 lands; setuptools accepts that without error.
Test plan