[doc][DOC-941] unpin tf-keras: 2.20.0 was yanked#63358
Conversation
Bump tf-keras 2.20.0 -> 2.20.1 in doc/requirements-doc.txt and python/deplocks/docs/docbuild_depset_py3.10.lock. 2.20.0 was yanked from PyPI (surfaced by the RtD build log on ray-project#63344). 2.20.1 has identical requires_dist (tensorflow<2.21,>=2.20), so the manual lock edit doesn't need a transitive refresh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request updates the tf-keras dependency to version 2.20.1 in the documentation requirements and lock file. The reviewer recommends updating all other requirement files referencing the yanked version for consistency and suggests regenerating lock files using standard tools rather than manual edits.
| requests==2.32.5 | ||
| tensorflow==2.20.0 | ||
| tf-keras==2.20.0 | ||
| tf-keras==2.20.1 |
There was a problem hiding this comment.
While this update addresses the yanked version for the documentation build, the PR description notes that other requirement files (e.g., dl-cpu-requirements.txt, dl-gpu-requirements.txt) and lockfiles still reference tf-keras==2.20.0. To ensure repository-wide consistency and prevent build failures in other components, it is recommended to update all occurrences of the yanked version in this PR rather than following up separately.
| tf-keras==2.20.1 \ | ||
| --hash=sha256:3f0e0a34d9a4c8758f24fdc1053e6e335f16ab5534c7d34f1899b8924779760c \ | ||
| --hash=sha256:884be5938fb0b2b53b1583c1ae2b660ef87215377c29b5b6a77fd221b472aeaf |
There was a problem hiding this comment.
Manual editing of lock files is generally discouraged as it can lead to inconsistencies in metadata or missed transitive dependency updates. It is safer to regenerate the lock file using the project's standard dependency management tool (e.g., pip-compile) to ensure all hashes and relationships are correctly captured and synchronized.
|
Both points are addressed in the PR body:
|
## Why `tf-keras==2.20.0` is pinned in `doc/requirements-doc.txt` and was yanked from PyPI. The RtD build log on [ray-project#63344](ray-project#63344) surfaced the warning: ``` WARNING: The candidate selected for download or install is a yanked version: 'tf-keras' candidate (version 2.20.0 at https://files.pythonhosted.org/packages/50/9b/.../tf_keras-2.20.0-py3-none-any.whl) Reason for being yanked: <none given> ``` The warning doesn't fail the build today (`fail_on_warning: true` doesn't catch yank warnings), but a yanked version may be removed from the index in the future and break the lock. ## What Patch bump to the next non-yanked release: - `doc/requirements-doc.txt`: `tf-keras==2.20.0` → `tf-keras==2.20.1`. - `python/deplocks/docs/docbuild_depset_py3.10.lock`: update the `tf-keras` entry with the 2.20.1 wheel and sdist hashes. 2.20.1 has identical `requires_dist` to 2.20.0 (`tensorflow<2.21,>=2.20`), so the existing `tensorflow==2.20.0` pin still satisfies the constraint and no transitive deps churn. Manual lock edit per the [ray-project#63130](ray-project#63130) pattern is appropriate here. The ML / `dl-cpu-requirements.txt` / `dl-gpu-requirements.txt` pins and the `doctest_depset` lockfile also reference 2.20.0; those are out of scope for this `doc`-tagged PR and can follow up separately. ## Verification RtD PR preview build with `fail_on_warning: true`. Confirm the yanked-version warning disappears and no new warnings appear. ## Context Part of the [DOC-932](https://anyscale1.atlassian.net/browse/DOC-932) campaign: Ray docs dependency upgrades. Independent of the other open probes ([ray-project#63343](ray-project#63343), [ray-project#63344](ray-project#63344), [ray-project#63354](ray-project#63354)) — targets `master` directly. [DOC-941](https://anyscale1.atlassian.net/browse/DOC-941) Signed-off-by: Douglas Strodtman <douglas@anyscale.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: phattruong <23120318@student.hcmus.edu.vn>
Why
tf-keras==2.20.0is pinned indoc/requirements-doc.txtand was yanked from PyPI. The RtD build log on #63344 surfaced the warning:The warning doesn't fail the build today (
fail_on_warning: truedoesn't catch yank warnings), but a yanked version may be removed from the index in the future and break the lock.What
Patch bump to the next non-yanked release:
doc/requirements-doc.txt:tf-keras==2.20.0→tf-keras==2.20.1.python/deplocks/docs/docbuild_depset_py3.10.lock: update thetf-kerasentry with the 2.20.1 wheel and sdist hashes.2.20.1 has identical
requires_distto 2.20.0 (tensorflow<2.21,>=2.20), so the existingtensorflow==2.20.0pin still satisfies the constraint and no transitive deps churn. Manual lock edit per the #63130 pattern is appropriate here.The ML /
dl-cpu-requirements.txt/dl-gpu-requirements.txtpins and thedoctest_depsetlockfile also reference 2.20.0; those are out of scope for thisdoc-tagged PR and can follow up separately.Verification
RtD PR preview build with
fail_on_warning: true. Confirm the yanked-version warning disappears and no new warnings appear.Context
Part of the DOC-932 campaign: Ray docs dependency upgrades. Independent of the other open probes (#63343, #63344, #63354) — targets
masterdirectly.DOC-941