Skip to content

[Data] Deprecate ConcurrencyCapBackpressurePolicy#63392

Merged
bveeramani merged 4 commits into
masterfrom
worktree-deprecate-concurrency-cap-backpressure
May 18, 2026
Merged

[Data] Deprecate ConcurrencyCapBackpressurePolicy#63392
bveeramani merged 4 commits into
masterfrom
worktree-deprecate-concurrency-cap-backpressure

Conversation

@bveeramani

@bveeramani bveeramani commented May 16, 2026

Copy link
Copy Markdown
Member

We introduced an experimental "dynamic queue size backpressure" six months ago in #57996.

This PR adds a warning that we're going to deprecate it in a few releases.

We've decided to deprecate it for a couple reasons:

  • It's hard to understand. The policy requires ~400 lines of control logic with multiple tunable constants, trend detection across two different signals (percentage growth and absolute growth), and sliding window history tracking.
  • It performed worse than the simpler DownstreamCapacityBackpressurePolicy in our experiments.
  • Removing the policy allows us to simplify the ResourceManager interface. ResourceManager is one of Ray Data's most involved modules.
Mark ConcurrencyCapBackpressurePolicy as deprecated with a removal
target of Ray 2.59. Emits a RayDeprecationWarning on instantiation.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani requested a review from a team as a code owner May 16, 2026 02:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the ConcurrencyCapBackpressurePolicy class by applying the @deprecated decorator. The reviewer suggested enhancing the deprecation message by including a recommended replacement policy to provide a clear migration path for users.

Emit the deprecation warning conditionally (only when
enable_dynamic_output_queue_size_backpressure is set), and add
unit tests for both the enabled and disabled cases.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f777ca4. Configure here.

@ray-gardener ray-gardener Bot added data Ray Data-related issues deprecation Scheduled for deprecation labels May 16, 2026
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani enabled auto-merge (squash) May 18, 2026 21:57
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label May 18, 2026
@bveeramani bveeramani merged commit 8c69fa9 into master May 18, 2026
7 of 8 checks passed
@bveeramani bveeramani deleted the worktree-deprecate-concurrency-cap-backpressure branch May 18, 2026 22:37
TruongQuangPhat pushed a commit to cyhapun/ray-fix-issue that referenced this pull request May 27, 2026
We introduced an experimental "dynamic queue size backpressure" six
months ago in ray-project#57996.

This PR adds a warning that we're going to deprecate it in a few
releases.

We've decided to deprecate it for a couple reasons:
* It's hard to understand. The policy requires ~400 lines of control
logic with multiple tunable constants, trend detection across two
different signals (percentage growth and absolute growth), and sliding
window history tracking.
* It performed worse than the simpler
`DownstreamCapacityBackpressurePolicy` in our experiments.
* Removing the policy allows us to simplify the `ResourceManager`
interface. `ResourceManager` is one of Ray Data's most involved modules.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: phattruong <23120318@student.hcmus.edu.vn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues deprecation Scheduled for deprecation go add ONLY when ready to merge, run all tests

2 participants