[serve] Enable splice in haproxy by default#63531
Merged
kouroshHakha merged 6 commits intoMay 20, 2026
Merged
Conversation
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the HAProxy configuration for Ray Serve by replacing the syslog port with a flexible log target and introducing a configurable buffer size (tune.bufsize). It also enables splice-request and splice-response options in the HAProxy template. Feedback suggests using get_env_str for the log target to maintain consistency and get_env_int_positive for the buffer size to prevent invalid non-positive values.
abrarsheikh
approved these changes
May 20, 2026
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
kouroshHakha
left a comment
kouroshHakha
left a comment
Contributor
There was a problem hiding this comment.
Do we need truncation now that we use splice to do zero copy?
kouroshHakha
approved these changes
May 20, 2026
Contributor
Author
still needed when body forwarding is used |
harshit-anyscale
added a commit
to harshit-anyscale/ray
that referenced
this pull request
May 21, 2026
Resolves conflicts from PR ray-project#63531 (splice + log consolidation): - haproxy_templates.py: collapse to single `log {{ config.log_target }}` per master; layer optional stderr access-log mirror on top. Keep both retry/redispatch (HEAD) and splice-request/splice-response (master) in the defaults block. - haproxy.py: union of imports (LOG_ACCESS_TO_STDERR + new INGRESS_* knobs + LOG_TARGET). - test_haproxy_api.py: expected_config reflects merged template ordering (retry block then splice block).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HAProxy splice moves bytes from recv socket to send socket directly, without needing to copy into user memory. This helps improves performance for large payloads. Splice does not happen if the request body needs to be inspected or modified (e.g. in the case of wait-for-body)
Also add an env var to tune bufsize. Also reduce the logging sinks from two to one.
Perf results: