Revert "[Data] Remove safe_round from ExecutionResources hot path (#6…

[elliot-barn]

Cherry pick 8178e12

[gemini-code-assist]

Code Review

This pull request simplifies resource quantization in ExecutionResources by rounding resource values directly in __init__ instead of using a lazy quantization cache (_quantized_key). This change removes the singleton caching for zero/infinite resources, simplifies comparison and hash methods, and updates associated tests to align with the new rounding behavior. Feedback on the changes points out that the updated __eq__ method lacks a type check for the other parameter, which could raise an AttributeError when comparing with other types, and suggests adding an isinstance check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The __eq__ method does not check if other is an instance of ExecutionResources before accessing its attributes (e.g., other.cpu). If other is None or an object of another type, this will raise an AttributeError. It is standard practice in Python to check the type of other and return NotImplemented if it is not of the expected type.

Suggested change

	def __eq__(self, other: "ExecutionResources") -> bool:
	return (
	self.cpu == other.cpu
	and self.gpu == other.gpu
	and self.object_store_memory == other.object_store_memory
	and self.memory == other.memory
	)
	def __eq__(self, other: object) -> bool:
	if not isinstance(other, ExecutionResources):
	return NotImplemented
	return (
	self.cpu == other.cpu
	and self.gpu == other.gpu
	and self.object_store_memory == other.object_store_memory
	and self.memory == other.memory
	)