Conversation
Signed-off-by: xuwwwww <113529937+xuwwwww@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the actor class loading logic in function_manager.py to use logger.exception instead of logger.debug when an error occurs, ensuring that the full traceback is captured. Additionally, a new test case has been added to verify that actor import errors are correctly logged. I have no further feedback to provide.
Signed-off-by: xuwwwww <113529937+xuwwwww@users.noreply.github.com>
rueian
approved these changes
Sep 30, 2026
rueian
enabled auto-merge (squash)
September 30, 2026 23:18
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 4ccb698. Configure here.
Signed-off-by: xuwwwww <113529937+xuwwwww@users.noreply.github.com>
auto-merge was automatically disabled
October 1, 2026 00:20
Head branch was pushed to by a user without write access
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
When an actor class fails to import on a worker, Ray logs the failure at DEBUG level and creates a temporary actor to report it later. In the case reported in #49285, the user saw an async actor startup error without the original
ModuleNotFoundErrorin the worker log.Log the import failure with its traceback at ERROR level. The temporary actor behavior stays the same. A focused test simulates a missing module and checks both the log and the existing fallback error. The test is registered in Bazel and includes a pytest entrypoint.
Related issues
Fixes #49285.
Additional information
I checked the issue and open PRs on 2026-09-29. The issue is open and unassigned, and I found no open PR for this log path.
Tests run on Windows:
..\ray-venv\Scripts\python.exe ..\..\outputs\run-ray-first-pr-test.py— 1 passed after the CI logging fix. This local helper loads the modifiedfunction_manager.pyover the Ray 2.58.0 binary wheel and sets theraylogger's propagation toFalseto reproduce the CI condition; it is not part of the PR.__main__entrypoint — 1 passed.BUILD.bazelwith Buildifier 8.0.1 on an LF-normalized copy; both passed.git diff --check— passed.AI assistance was used to investigate this issue and prepare the patch and test. The submitter ran the focused test locally.