[HS3] Align RooFit HS3 JSON I/O with the current HS3 naming and HistFactory conventions.#22735
Open
Phmonski wants to merge 2 commits into
Open
[HS3] Align RooFit HS3 JSON I/O with the current HS3 naming and HistFactory conventions.#22735Phmonski wants to merge 2 commits into
Phmonski wants to merge 2 commits into
Conversation
Test Results 20 files 20 suites 3d 8h 37m 25s ⏱️ For more details on these failures, see this check. Results for commit bf36555. |
Contributor
Author
|
This PR contains a bug that is investigated. |
bf36555 to
636e449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align RooFit HS3 JSON I/O with the current HS3 naming and HistFactory conventions.
RooBinWidthFunctionHS3 typebinwidthwith:binvolumefordivideByBinWidth == falseinverse_binvolumefordivideByBinWidth == truedivideByBinWidthand remove legacybinwidthimport support.floor,ceil,abs,tan,asin,acos,atan,PI, andEULER.PIandEULERas reserved expression constants on import.constraint_nametoconstraint, and omitconstraint_type.constraint,constraint_name, and legacyconstraint_type.const: truefor parameters whosemin >= max.RooHistFuncandParamHistFuncasstep.stepimporter dispatcher that selectsRooHistFuncfordataandParamHistFuncforparameters.histogramimport support for oldRooHistFuncHS3 files.Tests
Added focused coverage in
testRooFitHS3.cxxfor:binvolume/inverse_binvolumeexport and importconst: truestepexport/import dispatch forRooHistFuncandParamHistFuncconstraintexport with legacyconstraint_nameimport[x] Tested locally