Fixes for QNX SDP 8#158697
Open
jonathanpallant wants to merge 9 commits into
Open
Conversation
Linux [1], FreeBSD [2] and the Open Group [3] manuals for both setsid and setpgrp state that the calling process will be assigned a process group ID that matches its process ID so check that's the case in the test by calling getpgid on the child process ID. on QNX8 (as of GA8.0.2) libc::kill(pgid) appears unable to terminate the child process so skip that check on that target as it's behavior that libstd provides no API for [1]: https://man7.org/linux/man-pages/man2/setsid.2.html [2]: https://man.freebsd.org/cgi/man.cgi?query=setsid&sektion=2 [3]: https://pubs.opengroup.org/onlinepubs/000095399/functions/setsid.html
also extend the existing tests to exercise the getsockname(2) and getpeername(2) paths with both named and unnamed Unix sockets
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
r? @aapoalas rustbot has assigned @aapoalas. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Additional fixes library/std after earlier PR renamed some targets
Standardise on QNX SDP, because that's the thing you install and build against. QNX Neutrino and QNX OS are run-time details that are chosen for you by the SDP you have installed.
Tests ignored on target_os = "nto" should also be ignored on target_os = "qnx".
cc-rs now knows about QNX so the environment isn't required
jonathanpallant
force-pushed
the
qnx-sdp-8-fixes
branch
from
a1eb41c to
826c18d
Compare
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
Contributor
Author
Removed. |
aapoalas
approved these changes
Jul 3, 2026
| assert_eq!(pid, pgid, "child process ID does not match its process group ID"); | ||
|
|
||
| if cfg!(target_os = "qnx") { | ||
| // kill(-pgid) appears to be unable to terminate the child process on QNX8 |
Contributor
There was a problem hiding this comment.
question: This seems like a fairly big discrepancy - does this cause issues with user-facing process APIs as well?
| #[cfg(not(target_os = "nto"))] | ||
| #[cfg(not(any(target_os = "nto", target_os = "qnx")))] | ||
| const KEY_SENTVAL: usize = 0; | ||
| // On QNX Neutrino, 0 is always returned when currently not in use. |
Contributor
There was a problem hiding this comment.
nitpick:
Suggested change
| // On QNX Neutrino, 0 is always returned when currently not in use. | |
| // On QNX, 0 is always returned when currently not in use. |
Contributor
Author
There was a problem hiding this comment.
Fixed (and a few others too)
| //@ needs-subprocess | ||
| //@ ignore-fuchsia no exception handler registered for segfault | ||
| //@ ignore-nto Crash analysis impossible at SIGSEGV in QNX Neutrino | ||
| //@ ignore-qnx Crash analysis impossible at SIGSEGV in QNX Neutrino |
Contributor
There was a problem hiding this comment.
nitpick: These to presumably shouldn't talk about QNX Neutrino?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains libstd fixes so libstd can be build for QNX SDP 8.
It requires patches to libc-0.2 and cc-rs. The cc-rs patch was merged already. I have a patch for libc-1.0 here which will need backporting to libc-0.2 once merged.
With these in place, I was able to remotely
test tests/ui library/std library/alloc library/coreforx86_64-pc-qnxusing a remote-test-server running on QNX SDP 8.0's QEMU BSP image. The only tests that failed were the twotests/ui/codegen/huge-stacks.rstests, and I did not have enough RAM to run them.