Skip to content

Open index files in binary mode when loading #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim1999164 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Open index files in binary mode when loading #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/StreamUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class InputStream {
class FileInputStream : public InputStream {
public:
FileInputStream(const std::string &filename) : filename(filename) {
handle = fopen(filename.c_str(), "r");
// Open in binary mode so Windows does not alter bytes (CRLF translation).
handle = fopen(filename.c_str(), "rb");
if (!handle) {
throw std::runtime_error("Failed to open file for reading: " + filename);
}
Expand Down
3 changes: 2 additions & 1 deletion cpp/src/TypedIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ class TypedIndex : public Index {
* Save this index to the provided file path on disk.
*/
void saveIndex(const std::string &pathToIndex) {
algorithmImpl->saveIndex(pathToIndex);
// Write metadata + index once. Calling algorithmImpl->saveIndex first
// would overwrite the path with an index-only payload and break loads.
saveIndex(std::make_shared<FileOutputStream>(pathToIndex));
}

Expand Down