Add package supplier info to Tern reports - #1213
Merged
Merged
Conversation
This commit adds package supplier information as an attribute in the package class for package objects. For some package managers (like PyPI), there is only one feasible supplier (PyPI) and this value is set as a constant string (PyPI). For others, like rpm, the string is determined using the /etc/os-release file based on the Linux Distro providing the packages. While this is not a perfect way to determine the distro/distributor, it is satisfactory to satisfty the NTIA minimum elements for the upcoming EO 14028. We decided to use the distro as the supplier based on conversations had on the SPDX mailing list[1]. [1] https://lists.spdx.org/g/Spdx-tech/message/4942 Works towards tern-tools#1205 Signed-off-by: Rose Judge <rjudge@vmware.com>
This commit adds `pkg_supplier` attribute values as `PackageSupplier` field values in Tag Value and JSON SPDX documents . Resolves tern-tools#1205 Signed-off-by: Rose Judge <rjudge@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds package supplier information as an attribute in the
package class for package objects. This commit also adds
pkg_supplierattribute values asPackageSupplierfield values inTag Value and JSON SPDX documents .
For some package managers (like PyPI), there is only one feasible
supplier (PyPI) and this value is set as a constant string (PyPI). For
others, like rpm, the string is determined using the
/etc/os-releasefile based on the Linux Distro providing the packages. While this is
not a perfect way to determine the distro/distributor, it is satisfactory
to satisfty the NTIA minimum elements for the upcoming EO 14028.
We decided to use the distro as the supplier based on conversations
had on the SPDX mailing list[1].
[1] https://lists.spdx.org/g/Spdx-tech/message/4942
Resolves #1205