Skip to content

feat: add table_constraints dynamic block for primary_key and foreign_keys#388

Open
KuzmaTolyanuch wants to merge 15 commits into
terraform-google-modules:mainfrom
KuzmaTolyanuch:main
Open

feat: add table_constraints dynamic block for primary_key and foreign_keys#388
KuzmaTolyanuch wants to merge 15 commits into
terraform-google-modules:mainfrom
KuzmaTolyanuch:main

Conversation

@KuzmaTolyanuch

Copy link
Copy Markdown

This PR adds functionality available in bigquery_table terraform resource, but missing in BigGuery module

@google-cla

google-cla Bot commented Apr 21, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@drew-two

drew-two commented Dec 8, 2025

Copy link
Copy Markdown

Anything we can do to get this pushed along? It would save us a ton of time for our CDW

@g-awmalik g-awmalik changed the title Feature: add table_constraints dynamic block for primary_key and foreign_keys Jan 6, 2026
@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

@g-awmalik g-awmalik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the minor lint error.

@g-awmalik g-awmalik enabled auto-merge (squash) January 6, 2026 21:51
auto-merge was automatically disabled January 7, 2026 14:10

Head branch was pushed to by a user without write access

@KuzmaTolyanuch

Copy link
Copy Markdown
Author

Hi @g-awmalik,
Thank you for reviewing.
I pushed linting fix,
Could you please do "/gcbrun" to trigger CI/CD check.
Thank you in advance

@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

@g-awmalik g-awmalik enabled auto-merge (squash) January 10, 2026 20:18
auto-merge was automatically disabled January 12, 2026 15:19

Head branch was pushed to by a user without write access

@KuzmaTolyanuch

Copy link
Copy Markdown
Author

Hi @g-awmalik ,
Need another approval for pipeline run.
Hopefully the last one before merge.
I fixed trailing spaces and generated docker docs.
Please approve the run.
Thank you in advance.

@drew-two

Copy link
Copy Markdown

@g-awmalik Should be the last /gcbrun we need 🙏

Appreciate you!

@mehdicopter

Copy link
Copy Markdown

hello guys, when this PR will be merged ?

@g-awmalik

Copy link
Copy Markdown
Contributor

LGTM. Please review the lint errors.

@g-awmalik g-awmalik enabled auto-merge (squash) February 11, 2026 01:01
auto-merge was automatically disabled February 11, 2026 15:57

Head branch was pushed to by a user without write access

@KuzmaTolyanuch

Copy link
Copy Markdown
Author

Hi @g-awmalik,
Looks like the linting failure was caused by the generate docker docs automation.
Could you please trigger build once again?
Thank you in advance.

@noony

noony commented Mar 20, 2026

Copy link
Copy Markdown

Hi, any chance to see this released ? 🙏

@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

1 similar comment
@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

@g-awmalik

Copy link
Copy Markdown
Contributor

/gcbrun

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions Bot added the Stale label Jun 15, 2026
@jbragagnolo

Copy link
Copy Markdown

Hi @KuzmaTolyanuch and @terraform-google-modules maintainers!

First of all, thanks for putting this PR together. Adding support for table_constraints (primary and foreign keys) is a highly anticipated feature for anyone modeling relational structures directly inside BigQuery via Terraform.

Our team currently relies heavily on this module and this specific feature would prevent us from having to resort to manual workarounds or custom forks.

Is there anything missing or any feedback required to move forward with the review and CI checks? We would love to see this merged!

Thank you for your time and effort!

@github-actions github-actions Bot removed the Stale label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants