feat: add table_constraints dynamic block for primary_key and foreign_keys#388
feat: add table_constraints dynamic block for primary_key and foreign_keys#388KuzmaTolyanuch wants to merge 15 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Anything we can do to get this pushed along? It would save us a ton of time for our CDW |
|
/gcbrun |
g-awmalik
left a comment
There was a problem hiding this comment.
LGTM. Please fix the minor lint error.
Head branch was pushed to by a user without write access
|
Hi @g-awmalik, |
|
/gcbrun |
Head branch was pushed to by a user without write access
|
Hi @g-awmalik , |
|
@g-awmalik Should be the last /gcbrun we need 🙏 Appreciate you! |
|
hello guys, when this PR will be merged ? |
|
LGTM. Please review the lint errors. |
Head branch was pushed to by a user without write access
|
Hi @g-awmalik, |
|
Hi, any chance to see this released ? 🙏 |
|
/gcbrun |
1 similar comment
|
/gcbrun |
Increase sleep time for workflows
|
/gcbrun |
Increase polling for workflows in int test
|
/gcbrun |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Hi @KuzmaTolyanuch and @terraform-google-modules maintainers! First of all, thanks for putting this PR together. Adding support for Our team currently relies heavily on this module and this specific feature would prevent us from having to resort to manual workarounds or custom forks. Is there anything missing or any feedback required to move forward with the review and CI checks? We would love to see this merged! Thank you for your time and effort! |
This PR adds functionality available in bigquery_table terraform resource, but missing in BigGuery module