[WIP] [VALD-151] feat: Implement index importer by highpon · Pull Request #2952 · vdaas/vald

highpon · 2025-04-28T04:06:46Z

Description

Related Issue

Versions

Vald Version: v1.7.16
Go Version: v1.24.2
Rust Version: v1.86.0
Docker Version: v28.0.4
Kubernetes Version: v1.32.3
Helm Version: v3.17.2
NGT Version: v2.3.14
Faiss Version: v1.10.0

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

coderabbitai · 2025-04-28T04:06:53Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)

WIP
DO NOT MERGE
DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Post Copyable Unit Tests in Comment
Commit Unit Tests in branch feat/implement-vald-index-importer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2025-05-11T18:50:14Z

Deploying vald with Cloudflare Pages

Latest commit:	`f846bde`
Status:	✅ Deploy successful!
Preview URL:	https://54380b67.vald.pages.dev
Branch Preview URL:	https://feat-implement-vald-index-im.vald.pages.dev

View logs

vdaas-ci · 2025-05-11T18:50:29Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

github-actions · 2025-05-11T18:50:36Z

+FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder
+LABEL maintainer="vdaas.org vald team <vald@vdaas.org>"
+# skipcq: DOK-DL3002
+USER root:root


⚠️ [hadolint] <DL3002> _{reported by reviewdog 🐶}
Last USER should not be root

github-actions · 2025-05-11T18:50:36Z

+WORKDIR ${GOPATH}/src/github.com/${ORG}/${REPO}
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+#skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008
+RUN --mount=type=bind,target=.,rw \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

codecov · 2025-05-11T18:59:14Z

Codecov Report

❌ Patch coverage is 0% with 296 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.01%. Comparing base (d041587) to head (f846bde).
⚠️ Report is 81 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/index/job/importation/service/importer.go	0.00%	121 Missing ⚠️
pkg/index/job/importation/usecase/importation.go	0.00%	94 Missing ⚠️
pkg/index/job/importation/service/options.go	0.00%	32 Missing ⚠️
cmd/index/job/importation/main.go	0.00%	23 Missing ⚠️
pkg/index/job/importation/config/config.go	0.00%	22 Missing ⚠️
hack/docker/gen/main.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
- Coverage   17.34%   17.01%   -0.34%     
==========================================
  Files         129      134       +5     
  Lines       14542    14838     +296     
==========================================
+ Hits         2523     2524       +1     
- Misses      11729    12022     +293     
- Partials      290      292       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

highpon mentioned this pull request Apr 28, 2025

[WIP] feat: Implement index importer #2781

Closed

2 tasks

github-actions Bot mentioned this pull request May 1, 2025

Monthly review time metrics report: 2025-04-01..2025-04-30 #2955

Closed

highpon force-pushed the feat/implement-vald-index-importer branch from f335516 to 6bd23d4 Compare May 11, 2025 18:50

github-actions Bot reviewed May 11, 2025

View reviewed changes

github-actions Bot added area/internal type/ci area/makefile size/XL type/feature New feature priority/medium labels May 11, 2025

highpon changed the title ~~[WIP] feat: Implement index importer~~ May 12, 2025

highpon force-pushed the feat/implement-vald-index-importer branch from 3603acd to e27e6a5 Compare June 29, 2025 16:57

highpon added 4 commits June 30, 2025 01:57

fix: create templates for index-importation

dacd84d

[WIP] feat: Implement vald index-importer

f5cb377

tmp commit

e27e6a5

fix: refactor importer methods

f846bde

Navigation Menu

[WIP] [VALD-151] feat: Implement index importer - #2952

[WIP] [VALD-151] feat: Implement index importer#2952
highpon wants to merge 4 commits into
mainfrom
feat/implement-vald-index-importer

highpon commented Apr 28, 2025

coderabbitai Bot commented Apr 28, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages Bot commented May 11, 2025 •

edited

Loading

vdaas-ci commented May 11, 2025

github-actions Bot May 11, 2025

github-actions Bot May 11, 2025

codecov Bot commented May 11, 2025 •

edited

Loading

This branch has not been deployed

Labels

2 participants

Conversation

highpon commented Apr 28, 2025

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

coderabbitai Bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages Bot commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying vald with Cloudflare Pages

vdaas-ci commented May 11, 2025

github-actions Bot May 11, 2025

Choose a reason for hiding this comment

github-actions Bot May 11, 2025

Choose a reason for hiding this comment

codecov Bot commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

This branch has not been deployed

Labels

2 participants

coderabbitai Bot commented Apr 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages Bot commented May 11, 2025 •

edited

Loading

codecov Bot commented May 11, 2025 •

edited

Loading