Skip to content

[Bugfix] Add early validation to reject incompatible runner types for embedding models #43079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yewentao256 merged 5 commits into from
May 21, 2026
Merged

[Bugfix] Add early validation to reject incompatible runner types for embedding models #43079

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2f6857
[Bugfix] Add early validation to reject incompatible runner types for…
anishesg May 19, 2026
472f858
address review feedback: move validation before other checks and add …
anishesg May 19, 2026
6f2f71c
Merge branch 'main' into fix/ph-issue-43061
anishesg May 20, 2026
b771fcc
style: fix pre-commit line length in runner type validation
anishesg May 20, 2026
266c05e
Update tests/test_config.py
anishesg May 21, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions vllm/config/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,15 @@ def __post_init__(
architectures, self.runner_type, self.convert
)

if (
is_pooling_model
and not is_generative_model
and self.runner_type in ("draft", "generate")
):
raise ValueError(
f"Embedding models do not support `--runner {self.runner_type}`. "
"Use `--runner pooling` or `--runner auto` for embedding models."
)
if self.runner_type == "generate" and not is_generative_model:
generate_converts = _RUNNER_CONVERTS["generate"]
if self.convert_type not in generate_converts:
Expand Down
Loading