[XPU] Cap topk/topp Triton BLOCK_SIZE to 4096 to fix Top-p mask difference failures#44470
Merged
jikunshang merged 1 commit intoJun 8, 2026
Merged
Conversation
chaojun-zhang
requested review from
22quinn,
Harry-Chen,
houseroad,
khluu and
njhill
as code owners
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
chaojun-zhang
force-pushed
the
sample_topk_topp_triton_fix
branch
from
7ea0bd7 to
b829201
Compare
jikunshang
approved these changes
Jun 8, 2026
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Jun 9, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
ohsono
pushed a commit
to ohsono/vllm
that referenced
this pull request
Jul 3, 2026
…rence failures (vllm-project#44470) Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cap the Triton
BLOCK_SIZEto 4096 intopk_topp_triton.pyon XPU to fixTop-p mask difference too largetest failures.Changes
vllm/v1/sample/ops/topk_topp_triton.py: limit XPU block size to 4096 for deterministic sampling.buildkite/intel_jobs/misc_intel.yaml: enabletest_topk_topp_sampler.pyon XPU CI