[Connector] Remove P2pNcclConnector#44854
Merged
Merged
Conversation
NickLucche
requested review from
ApostaC,
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
orozery,
robertgshaw2-redhat,
tlrmchlsmth,
xuechendi,
yewentao256 and
youkaichao
as code owners
![claude[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Documentation preview: https://vllm--44854.org.readthedocs.build/en/44854/ |
mergify
Bot
added
documentation
hmellor
approved these changes
Jun 8, 2026
This was referenced Jun 8, 2026
This was referenced Jun 8, 2026
liulanze
added a commit
to liulanze/vllm
that referenced
this pull request
Jun 8, 2026
docs/features/disagg_prefill.md referenced examples/disaggregated/disaggregated_prefill.sh which was deleted by vllm-project#44854. MkDocs --strict mode aborts on broken links. Signed-off-by: Lanze Liu <lanzetech@gmail.com>
This was referenced Jun 8, 2026
4 tasks
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Jun 9, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
4 tasks
ohsono
pushed a commit
to ohsono/vllm
that referenced
this pull request
Jul 3, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some more recent dicussions, for the same reasons listed here #33115, we've decided to remove the
P2pNcclConnector.I would still like to thank @Abatom and everyone who was contributed to the connector as this helped PD take off the ground in its early stages.
Mind that similar connectors can still be implemented OOT leveraging the current ConnectorAPI.