[Cohere] Cohere2 moe parser fix#44907
Merged
Merged
Conversation
Signed-off-by: Terrencezzj <terrence@cohere.ai>
Signed-off-by: Terrencezzj <terrence@cohere.ai>
sfeng33
reviewed
Jun 8, 2026
| ] | ||
|
|
||
| expert_params_mapping = FusedMoE.make_expert_params_mapping( | ||
| expert_params_mapping = fused_moe_make_expert_params_mapping( |
Collaborator
There was a problem hiding this comment.
Is this needed for tool parser fix
Contributor
Author
There was a problem hiding this comment.
No, but it breaks our model. The PR caused this was merged this morning #41184
mgoin
approved these changes
Jun 9, 2026
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Jun 9, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai> Signed-off-by: divineearthly <divineearthly@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai>
ohsono
pushed a commit
to ohsono/vllm
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Terrencezzj <terrence@cohere.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Before fix:
After fix
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.