[EPLB] Reject NCCL-based EPLB communicators with async EPLB#44978
Merged
tlrmchlsmth merged 6 commits intoJun 10, 2026
Conversation
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
ilmarkov
requested review from
AndreasKaratzas,
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256,
youkaichao and
zyongye
as code owners
tlrmchlsmth
approved these changes
Jun 9, 2026
Open
wcynb1023
pushed a commit
to wcynb1023/vllm
that referenced
this pull request
Jun 11, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…ject#44978) Signed-off-by: Markov Ilya <markovilya197@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCCL is fundamentally incompatible with async EPLB due to multi-stream conflicts (see pytorch/pytorch#174288). Previously, the auto-selection logic avoided torch_nccl for async EPLB, but users could still explicitly set communicator="torch_nccl" or communicator="pynccl" and hit hangs. This PR adds explicit validation to catch these invalid combinations early
The DeepEP low-latency + async EPLB case that previously needed the NCCL_MAX_CTAS workaround in
eplb_utils.pycan no longer occur because NCCL-based communicators are now rejected at config validation when async EPLB is enabled. The workaround is simplified to only cover the DeepGEMM Mega MoE case.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.