[Bugfix] Fix Llama4 weight loading#45047
Merged
robertgshaw2-redhat merged 2 commits intoJun 10, 2026
Merged
Conversation
The MoE refactor (vllm-project#41184) moved expert weights under a routed_experts submodule but the remap function only handled .mlp.experts. paths. Models using .feed_forward.experts. (Llama4, mllama4, lfm2_moe) hit KeyError on scale params like w2_input_scale during weight loading. Generalize maybe_remap_moe_expert_param_name to match any *.experts.* pattern and add remap calls in the affected models' weight loaders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
bnellnm
approved these changes
Jun 9, 2026
bnellnm
left a comment
bnellnm
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix. I was just looking into this.
hmellor
approved these changes
Jun 9, 2026
robertgshaw2-redhat
merged commit fa8c868
into
vllm-project:main
67 of 70 checks passed
wcynb1023
pushed a commit
to wcynb1023/vllm
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vivek8123
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MoE refactor (#41184) moved expert weights under a routed_experts submodule but the remap function only handled .mlp.experts. paths. Models using .feed_forward.experts. (Llama4, mllama4, lfm2_moe) hit KeyError on scale params like w2_input_scale during weight loading.
Generalize maybe_remap_moe_expert_param_name to match any .experts. pattern and add remap calls in the affected models' weight loaders.
Fixes Nightly CI build #70731: